Repository navigation
[workshop-diagrams] Add theme-aware explanatory diagram for orchestrator routing - #3053
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
marked this pull request as ready for review
September 8, 2026 12:51
pelikhan
deleted the
add-orchestrator-routing-diagram-6ee8ba4528248c71
branch
September 8, 2026 12:51
There was a problem hiding this comment.
🔵 Needs a closer look
The new SVGs have verified accessibility/rendering issues (badge text contrast in light mode and unquoted multi-word font-family values) that should be corrected before merge.
Pull request overview
Adds a theme-aware conceptual diagram to the orchestration workshop step to visually explain how repo-orchestrator evaluates repository signals and routes to exactly one specialist workflow (or skips).
Changes:
- Added new light and dark SVG diagrams illustrating orchestrator routing and the “max: 1 dispatch per run” rule.
- Embedded the diagrams into
workshop/28-orchestrate-workflows.mdusing the existing theme-aware<picture>pattern.
File summaries
| File | Description |
|---|---|
| workshop/28-orchestrate-workflows.md | Inserts a theme-aware <picture> block for the new diagram directly after the dispatch-workflow introduction. |
| workshop/images/28-orchestrator-routing-light.svg | Adds the light-mode diagram asset (needs contrast + font-family parsing fixes). |
| workshop/images/28-orchestrator-routing-dark.svg | Adds the dark-mode diagram asset (needs font-family parsing fixes). |
Review details
- Files reviewed: 1/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new conceptual diagram to
workshop/28-orchestrate-workflows.mdillustrating how therepo-orchestratorworkflow reads repository signals (schedule trigger, PR age, status-issue history) and routes to exactly one specialist workflow viadispatch-workflow, or logs a summary and exits when no condition matches.This is a new concept, not a migration — the file previously had zero images.
Files added
workshop/images/28-orchestrator-routing-light.svgworkshop/images/28-orchestrator-routing-dark.svgFiles changed
workshop/28-orchestrate-workflows.md— inserted one theme-aware<picture>block directly after thedispatch-workflowintroduction, using the canonical light/dark pattern with alt text on the fallback<img>.Why this helps learners
The step explains orchestration entirely in prose and a decision table. A diagram makes the trigger → orchestrator → three-way routing decision (dispatch PR reviewer, dispatch daily-status, or skip) visually explicit, reinforcing the "dispatch at most one specialist per run" rule that the checkpoint asks learners to explain.
QA performed
node scripts/check-svg-visual-language.jspasses with 0 violations for both SVGs (Primer state colors applied correctly to in-progress/skipped badges).<picture>block locally with Playwright in bothlightanddarkcolor schemes; confirmedcurrentSrcresolves to the matching-light.svg/-dark.svgvariant in each case.Warning
Firewall blocked 6 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comregistry.npmjs.orgwww.google.comwww.gstatic.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.