Skip to content

[workshop-diagrams] Add theme-aware explanatory diagram for orchestrator routing - #3053

Merged
pelikhan merged 1 commit into
mainfrom
add-orchestrator-routing-diagram-6ee8ba4528248c71
Sep 8, 2026
Merged

pelikhan merged 1 commit into
mainfrom
add-orchestrator-routing-diagram-6ee8ba4528248c71

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a new conceptual diagram to workshop/28-orchestrate-workflows.md illustrating how the repo-orchestrator workflow reads repository signals (schedule trigger, PR age, status-issue history) and routes to exactly one specialist workflow via dispatch-workflow, or logs a summary and exits when no condition matches.

This is a new concept, not a migration — the file previously had zero images.

Files added

  • workshop/images/28-orchestrator-routing-light.svg
  • workshop/images/28-orchestrator-routing-dark.svg

Files changed

  • workshop/28-orchestrate-workflows.md — inserted one theme-aware <picture> block directly after the dispatch-workflow introduction, using the canonical light/dark pattern with alt text on the fallback <img>.

Why this helps learners

The step explains orchestration entirely in prose and a decision table. A diagram makes the trigger → orchestrator → three-way routing decision (dispatch PR reviewer, dispatch daily-status, or skip) visually explicit, reinforcing the "dispatch at most one specialist per run" rule that the checkpoint asks learners to explain.

QA performed

  • node scripts/check-svg-visual-language.js passes with 0 violations for both SVGs (Primer state colors applied correctly to in-progress/skipped badges).
  • Rendered the <picture> block locally with Playwright in both light and dark color schemes; confirmed currentSrc resolves to the matching -light.svg / -dark.svg variant in each case.
  • Visual screenshots in both themes show all labels contained within their boxes/badges with no clipping or overlap.

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

  • accounts.google.com
  • android.clients.google.com
  • clients2.google.com
  • registry.npmjs.org
  • www.google.com
  • www.gstatic.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "registry.npmjs.org"
    - "www.google.com"
    - "www.gstatic.com"

See Network Configuration for more information.

Generated by 🧠 Workshop Explanatory Diagram Generator · copilot · auto · 112 AIC · ⌖ 22.7 AIC · ⊞ 11.1K · ◷

  • expires on Sep 9, 2026, 2:41 AM UTC

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review September 8, 2026 12:51
Copilot AI lite review requested due to automatic review settings September 8, 2026 12:51
@pelikhan
pelikhan merged commit 6418a3c into main Sep 8, 2026
1 check passed
@pelikhan
pelikhan deleted the add-orchestrator-routing-diagram-6ee8ba4528248c71 branch September 8, 2026 12:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The new SVGs have verified accessibility/rendering issues (badge text contrast in light mode and unquoted multi-word font-family values) that should be corrected before merge.

Pull request overview

Adds a theme-aware conceptual diagram to the orchestration workshop step to visually explain how repo-orchestrator evaluates repository signals and routes to exactly one specialist workflow (or skips).

Changes:

  • Added new light and dark SVG diagrams illustrating orchestrator routing and the “max: 1 dispatch per run” rule.
  • Embedded the diagrams into workshop/28-orchestrate-workflows.md using the existing theme-aware <picture> pattern.
File summaries
File Description
workshop/28-orchestrate-workflows.md Inserts a theme-aware <picture> block for the new diagram directly after the dispatch-workflow introduction.
workshop/images/28-orchestrator-routing-light.svg Adds the light-mode diagram asset (needs contrast + font-family parsing fixes).
workshop/images/28-orchestrator-routing-dark.svg Adds the dark-mode diagram asset (needs font-family parsing fixes).
Review details
  • Files reviewed: 1/3 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants