Repository navigation
[workshop-diagrams] Add theme-aware explanatory diagram for pattern triage flow - #4561
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Add a light/dark SVG diagram illustrating the 5-pattern triage flow (run output -> match pattern -> micro-step -> checklist, with a loop-back for unresolved symptoms) to the debug output side quest landing page, replacing the previous text-only pattern table intro. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
This pull request was automatically closed because it expired on 2026-10-15T02:42:58.614Z.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new conceptual diagram to
workshop/side-quest-09-01-debug-output.md(no existing images to migrate in this file).workshop/side-quest-09-01-debug-output.mdworkshop/images/side-quest-09-01-pattern-triage-flow-light.svgworkshop/images/side-quest-09-01-pattern-triage-flow-dark.svgWhy this helps learners
The side quest page presents five diagnostic patterns only as a prose table plus a link to a separate checklist page. The new diagram makes the overall triage flow visible at a glance: Run Output → match against 5 known patterns → open the matching micro-step → confirm with the full Debugging Checklist, with a dashed loop-back arrow showing what to do if the symptom is still unclear. This gives learners a mental model before they dive into the five individual micro-steps.
Implementation notes
1200x560, matches the workshop's established light/dark palette (#f2f5f3/#101411backgrounds,#08872b/#5fed83accents).workflow/playOcticon path (unmodified geometry) for the run-output node; other nodes use plain shapes since they aren't GitHub entities.role="img",aria-label,data-visual-kind="diagram", and a stabledata-visual-idare set on the SVG root;data-nodeon each stage.<picture>block insertion (6 lines) using the canonical theme-aware pattern, with the light variant as the<img>fallback and alt text only on<img>.Validation performed
node scripts/check-svg-visual-language.jsrun against both new SVGs — no violations.<picture>block with Playwright in bothlightanddarkcolorScheme, confirmedcurrentSrcresolves to-light.svgand-dark.svgrespectively.Warning
Firewall blocked 7 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comregistry.npmjs.orgupdate.googleapis.comwww.google.comwww.gstatic.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.