You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AccountAuthenticationProvider has had inheritance from AuthenticationProvider of VSCode for being registered in VSCode as an account provider.
In #3524 we have stopped registering our provider in VSCode, so technically we the inheritance is not necessary anymore. So we can consider removal, but also we might decide to leave it as is.
I suppose the decision depends on the following:
On the one hand, AccountAuthenticationProvider in its current state may contain methods that are implemented only to satisfy inheritance of AuthenticationProvider but are not actually in use anymore.
On the other hand, the parent class can contain some methods that are in use and that will need to be re-implemented.
Therefore we need to weigh whether it's worth or not to remove the inheritance and implement. We can make the decision by:
just starting the replacement and seeing how it goes
analising the current code
however, maybe Eric or Keith or Ramin can say it immediately without even touching the code
So, if we decide to rid of the inheritance it should be done in this ticket. If we decide to leave the inheritance, this ticket can be just closed as "won't do"
The text was updated successfully, but these errors were encountered:
AccountAuthenticationProvider has had inheritance from AuthenticationProvider of VSCode for being registered in VSCode as an account provider.
In #3524 we have stopped registering our provider in VSCode, so technically we the inheritance is not necessary anymore. So we can consider removal, but also we might decide to leave it as is.
I suppose the decision depends on the following:
Therefore we need to weigh whether it's worth or not to remove the inheritance and implement. We can make the decision by:
So, if we decide to rid of the inheritance it should be done in this ticket. If we decide to leave the inheritance, this ticket can be just closed as "won't do"
The text was updated successfully, but these errors were encountered: