Change GK account authentication to no longer use the VS Code authentication system

[sergeibbb]

Currently we leverage the VS Code authentication system for our GK authentication, but this causes unnecessary prompts and limits our control over the experience.

We already implement both sides of the authentication process within GitLens, so we just need to avoid using VS Code as the middleman

Roadmap

• stop registering AccountAuthenticationProvider in VSCode
• fix get-or-create behavior and honoring createIfNeeded and silent flags.
• ❌ probably stop implementing AuthenticationProvider ➡️ probably but in a follow-up
• stop relying on authentication events, e.g. stop handling them and make sure that we loos nothing by doing that (or fix the cases that are broken) I've checked that don't relying on such events for GK authentication.

Testing notes

• Be unauthenticated before the update:
  • general behavior
    • login
    • restart VS Code: you should keep your session
    • logout
    • login again
    • logout
    • restart VS Code: you should keep being unauthenticated.
  • integrations
    • you're able to connect-disconnect rich GitHub integration,
    • they survive restarting the application.
    • disconect GitHub, then go to the Account View, press "Integrations" button, come back to VS Code. Integrations become connected.
• Be authenticated before the update
  • check the integrations behavior from the previous section
  • check the general behavior from the previous section
• Test both "sign-in" and "sign-up" flows, when you're authenticated and unauthenticated in your browser

[sergeibbb]

hi @eamodio

If I understand the task correctly it looks like we should:

1. stop registering AccountAuthenticationProvider in VSCode
2. probably stop implementing AuthenticationProvider because there is no need of that. (I'm not sure yet whether it's true or false).
3. therefore stop relying on authentication events, e.g. stop handling them and make sure that we loos nothing by doing that (or fix the cases that are broken)

We already save sessions to the secret storage, so probably nothing new should appear that would be related to the session management.

Is this understanding correct in general?

[sergeibbb]

Hi @eamodio

Here is updated version of the question above:

#1 - I've stop registering AccountAuthenticationProvider in VSCode
#3 - I've checked that don't relying on such events for GK authentication

So, now everything works as expected.

The rest question is #2: should I stop implementing AuthenticationProvider? Now it's left without changes and everything looks working.

And one more question will be in a comment related to the code: #3524 (comment)

cc @axosoft-ramint

[sergeibbb]

@axosoft-ramint @eamodio

I'm not sure that this is the right way of accessing the session: retrieving an array of matching sessions and taking the first one. Can you confirm or suggest a better way?

[axosoft-ramint]

LGTM

[sergeibbb]

Hi @eamodio @axosoft-ramint

I've created a follow up ticket: #3574
I suppose, it needs to be prioritized, milestonized, etc.