Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect if www is missing #2659

Closed
chrifro opened this issue Jan 4, 2021 · 3 comments · Fixed by #3035
Closed

Add redirect if www is missing #2659

chrifro opened this issue Jan 4, 2021 · 3 comments · Fixed by #3035
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@chrifro
Copy link

chrifro commented Jan 4, 2021

Describe the bug

according to @nisarhassan12 this is probably something that has to be implemented on the server side (https://github.com/gitpod-io/website/issues/842#issuecomment-739048822)

@svenefftinge
Copy link
Member

A simple solution for gitpod.io could be to forward to www.(URL) in case of 404. @geropl WDYT?

@geropl
Copy link
Member

geropl commented Jan 5, 2021

Yes, adding a error handler for 404 here should do the trick: https://github.com/gitpod-io/gitpod/blob/master/chart/config/proxy/lib.locations.conf#L45

@AlexTugarev
Copy link
Member

@geropl, 'you mean an error_page inside of the location /, right?
I'm wondering how to verify 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants