Redirect to www. if 404 Not Found #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
reviewed
Jan 29, 2021
| @@ -17,7 +17,7 @@ cd /etc/nginx/ | |||
|
|
|||
| replaceEnvVars() { | |||
| echo "Updating $i" | |||
| envsubst '$KUBE_NAMESPACE,$PROXY_DOMAIN_REGEX,$PROXY_DOMAIN_COOKIE,$NAMESERVER,$SERVER_PROXY_APIKEY' < $1 > /tmp/foo; | |||
| envsubst '$KUBE_NAMESPACE,$PROXY_DOMAIN,$PROXY_DOMAIN_REGEX,$PROXY_DOMAIN_COOKIE,$NAMESERVER,$SERVER_PROXY_APIKEY' < $1 > /tmp/foo; | |||
geropl
reviewed
Jan 29, 2021
| } | ||
|
|
||
| location @error_404_dashboard { | ||
| return 302 https://www.${PROXY_DOMAIN}$request_uri; |
There was a problem hiding this comment.
I wonder if the assumption that there is a www. subdomain is new - I bet not. Also, would be nice if this is configurable, as "landing page", e.g.
But I think this is fine for now, especially as we want to test if this breaks sth on staging.
geropl
approved these changes
Jan 29, 2021
|
BTW: Created https://github.com/gitpod-com/gitpod-dev/issues/45 so we can test things like this (redirects to landing page) in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@geropl's idea from #2659 (comment) written in code. 🙏🏻
The suggestion is to test this on staging and see if that fits.
I find it hard to test on dev, because there is nothing in the ingress proxy of the dev staging to handle the
www.URLs. (Gero mentioned, we can add this. But it's also nothing we miss ATM.)Resolves #2659