-
Notifications
You must be signed in to change notification settings - Fork 75
Conversation
@jankeromnes @svenefftinge can you take a look at this |
languages_and_frameworks.md
languages_and_frameworks.md
and extend python_in_gitpod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JesterOrNot, many many thanks for improving our "Languages & Frameworks" section! You're so fast that it's not easy to keep up. 😅
For this Pull Request, I think you didn't mean to propose all these changes to:
src/components/*
src/pages/*
src/resources/*
src/utils/link.tsx
To remove the noise, I will now squash all your commits into one, and only keep the changes to:
src/docs/*
I hope that's ok with you. 🙂
Also, please always try to avoid "Merge" commits here. They make the commit history messy (it becomes a mashed-up tree instead of a straightforward linear progression) for no clear benefits. Note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your great work here!
The improvements to the Java page are excellent, many thanks. I'd like to merge them as is.
For the Julia page, it still seems pretty small. If I'm a Julia developer who is new to Gitpod, I'm not sure if this page will really help me configure my own Julia project so that it works well in Gitpod.
I mean sure, looking at the example repositories may give me a clue about what I need to configure, but if I've never seen a Gitpod configuration in my life, or even written a Dockerfile, this may all be too much to deal with (and maybe I'll give up trying to set up Gitpod).
For the Python page, it's pretty cool to have .gitpod.yml
and .gitpod.Dockerfile
examples, but maybe we don't want to put very long & complicated configurations in front of our new users. So maybe it's better to just cover the basics, e.g. say what exactly you need to do if you want to use wxPython
in Gitpod, and then have external links to the full configurations if users want them.
I took the liberty to split out the Java and Julia guide improvements, which are now merged separately into This PR is actually about the Python guide. Let's update it to reflect that. |
languages_and_frameworks.md
and extend python_in_gitpod
1e5346e
to
5299d6b
Compare
@jankeromnes can you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool post! The wxPython
section is starting to look good. However, I feel like there should some content before that section (not all Python developers want to work with wxPython
).
Specifically, I think we should mention cool Python example repositories, and any VS Code extensions that could be interesting to install (if there are some that are worth it?)
Here are a few Python example repos from the top of my head:
- https://github.com/gitpod-io/django-locallibrary-tutorial MDN's local library Django application example (our default Python example for Gitpod)
- https://github.com/techwithtim/Hangman A graphical Hangman game based on pygame and Gitpod's VNC image (pretty fun to play! however you'll need to increase the preview pane width in order to even see the pygame window)
- https://github.com/techwithtim/NEAT-Flappy-Bird A graphical AI playground that teaches generational AI agents to win the game Flappy Bird (same thing with the preview width)
- https://github.com/openai/gym An AI framework from OpenAI (the config lives in the external definitely-gp repository though)
- https://github.com/TheAlgorithms/Python is a cool example for running Python algorithms in Gitpod, but it doesn't have any special setup/configuration (could be a good example that Python "just works" in Gitpod without needing any config)
I don't know about VS Code extensions though.
Don't worry on the examples front I have a lot of examples ready to be added! |
see #383 |
The Examples section looks cool! Many thanks. I feel like it should come before the
|
I'll move it Jan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the recent fixes! I've added a few more comments / suggestions.
Also, do you know any VS Code extensions that would be useful for Python? (If you don't need any, that's cool too though.)
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool! Thanks a lot for the great work on this guide.
This seems ready to go, except for a minor problem in the Dockerfile. Please fix it, and then we'll be able to "Squash & Merge" all these commits. 👍
Fixed! |
As mentioned on Slack, please open a follow-up PR to mention which Python versions are supported in Gitpod, and how to switch from one to the other (e.g. with a brief |
So merge this and then open a separate PR? |
ok |
Many thanks @JesterOrNot! And yes please :) |
No description provided.