This repository has been archived by the owner on Apr 19, 2021. It is now read-only.
Add Golang to Languages and Frameworks #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
reviewed
Jan 7, 2020
jankeromnes
reviewed
Jan 8, 2020
jankeromnes
changed the title
jankeromnes
changed the title
Signed-off-by: Sean Hellum <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
jankeromnes
reviewed
Jan 9, 2020
There was a problem hiding this comment.
This is looking almost final! Many thanks for writing a Go guide so fast.
I added a small comment about a confusing phrasing; a confusing title; and I made a general comment about the tone of this article and who it should be written for. 🙂
All-in-all, I think we'll be able to merge this soon. Thanks again! 💯
jankeromnes
reviewed
Jan 10, 2020
Co-Authored-By: Jan Keromnes <[email protected]>
jankeromnes
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Perfect, many thanks! I think we can merge this as an initial version, and then iterate on it later (e.g. when Go debugging works 😊).
Before merging though, let's wait for Netlify's deployment, to give a quick look at the rendered page (and maybe catch any potentially remaining markdown bugs).
|
Looks good! |
|
@jankeromnes the netlify deployment looks good |
JesterOrNot
changed the title
JesterOrNot
changed the title
JesterOrNot
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Golang to languages and frameworks
see #383