This repository has been archived by the owner on Apr 19, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
force-pushed
the
JesterOrNot/shell
branch
from
January 7, 2020 14:19
4d73313
to
ebefd5d
Compare
I took the liberty to clean up your commits and splice out any changes from other Pull Requests. 🙂 Easier to review now. |
jankeromnes
reviewed
Jan 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks a lot @JesterOrNot! 💯 I added a few comments below. Please take a look at them when you have time. 🙂
Please rebase your Pull Request on top of the latest It's actually pretty easy. Please do this:
At the end, it should say that the rebase was successful. 👍 EDIT: And when the rebase is successful (make sure it's finished by looking at |
jankeromnes
reviewed
Jan 8, 2020
jankeromnes
reviewed
Jan 8, 2020
jankeromnes
reviewed
Jan 8, 2020
jankeromnes
reviewed
Jan 8, 2020
JesterOrNot
force-pushed
the
JesterOrNot/shell
branch
from
January 17, 2020 22:26
7c6bf07
to
1c90eb7
Compare
jankeromnes
force-pushed
the
JesterOrNot/shell
branch
3 times, most recently
from
January 23, 2020 17:25
1bbfd01
to
c34dba4
Compare
Kreyren
reviewed
Jan 25, 2020
JesterOrNot
force-pushed
the
JesterOrNot/shell
branch
4 times, most recently
from
February 3, 2020 20:31
00d3b43
to
f899f8f
Compare
JesterOrNot
force-pushed
the
JesterOrNot/shell
branch
from
February 4, 2020 19:24
2fdd863
to
dcc247e
Compare
JesterOrNot
force-pushed
the
JesterOrNot/shell
branch
from
February 5, 2020 02:43
84858c8
to
faeb7b6
Compare
JesterOrNot
force-pushed
the
JesterOrNot/shell
branch
from
February 5, 2020 02:50
058d7d7
to
978aec7
Compare
nisarhassan12
approved these changes
Feb 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bash to languages_and_frameworks
Please see #383