-
Notifications
You must be signed in to change notification settings - Fork 75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool start for the Ruby guide! Many thanks. 👍
Some comments, as usual. 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, many thanks!
I found a few small issues, but this also looks about ready to be merged. :)
Ah, we should probably also mention which Ruby versions we ship with by default, and what version manager we use (please check the workspace-full Dockerfile for that). Also, an example of how you can use a different Ruby version than the default would be cool (I think dev.to's |
df584aa
to
7814aa8
Compare
2b93cbc
to
31f74e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool! Thanks for the great work.
More comments in-line. 😊
0319987
to
efc4374
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super-clean rebase! Well done. 👏 💯
Also, this guide is looking almost final now. Just a few minor things to address, and we'll be able to merge. Thanks for the great work!
add intro add VSCode section with example image add .gitpod.yml info add more extensions Update src/docs/ruby_in_gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> Update src/docs/ruby_in_gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> add examples [docs] Add Julia to 'Languages and frameworks' section and improve Python modified: src/docs/languages_and_frameworks.md modified: src/docs/python_in_gitpod.md add empty line fix update update update link Mention default Ruby version Add stub for `Popular Ruby Frameworks in Gitpod` section Update src/docs/julia-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> Update src/docs/ruby-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> Update src/docs/ruby-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> Update src/docs/ruby-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> Update src/docs/ruby-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> Update src/docs/ruby-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> Update src/docs/ruby-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> Update src/docs/ruby-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> update put it on it's own line Update src/docs/ruby-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> Update src/docs/ruby-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> Update src/docs/ruby-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> Update src/docs/ruby-in-gitpod.md Co-Authored-By: Jan Keromnes <[email protected]> move ruby version section reworded
c7f0574
to
530180e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This is almost perfect, approved with a few small adjustments. 💯
After that, go for launch! 🚀
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
This is the start of Ruby in Gitpod for languages and Frameworks
See #383