Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

Ruby Languages and frameworks #388

Merged
merged 6 commits into from
Jan 22, 2020

Conversation

JesterOrNot
Copy link
Contributor

This is the start of Ruby in Gitpod for languages and Frameworks
See #383

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool start for the Ruby guide! Many thanks. 👍

Some comments, as usual. 😊

src/docs/ruby_in_gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby_in_gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby_in_gitpod.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, many thanks!

I found a few small issues, but this also looks about ready to be merged. :)

src/docs/julia_in_gitpod.md Outdated Show resolved Hide resolved
src/docs/languages_and_frameworks.md Outdated Show resolved Hide resolved
src/docs/python_in_gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby_in_gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby_in_gitpod.md Outdated Show resolved Hide resolved
@jankeromnes
Copy link
Contributor

jankeromnes commented Jan 20, 2020

Ah, we should probably also mention which Ruby versions we ship with by default, and what version manager we use (please check the workspace-full Dockerfile for that).

Also, an example of how you can use a different Ruby version than the default would be cool (I think dev.to's .gitpod.yml does something like reading a local .ruby-version file and running the appropriate command with what it found)

@JesterOrNot JesterOrNot changed the title [WIP] Ruby Languages and frameworks Ruby Languages and frameworks Jan 21, 2020
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! Thanks for the great work.

More comments in-line. 😊

src/docs/julia-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super-clean rebase! Well done. 👏 💯

Also, this guide is looking almost final now. Just a few minor things to address, and we'll be able to merge. Thanks for the great work!

src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
add intro

add VSCode section with example image

add .gitpod.yml info

add more extensions

Update src/docs/ruby_in_gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

Update src/docs/ruby_in_gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

add examples

[docs] Add Julia to 'Languages and frameworks' section and improve Python

	modified:   src/docs/languages_and_frameworks.md
  	modified:   src/docs/python_in_gitpod.md

add empty line

fix

update

update

update link

Mention default Ruby version

Add stub for `Popular Ruby Frameworks in Gitpod` section

Update src/docs/julia-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

Update src/docs/ruby-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

Update src/docs/ruby-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

Update src/docs/ruby-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

Update src/docs/ruby-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

Update src/docs/ruby-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

Update src/docs/ruby-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

Update src/docs/ruby-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

update

put it on it's own line

Update src/docs/ruby-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

Update src/docs/ruby-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

Update src/docs/ruby-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

Update src/docs/ruby-in-gitpod.md

Co-Authored-By: Jan Keromnes <[email protected]>

move ruby version section

reworded
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is almost perfect, approved with a few small adjustments. 💯

After that, go for launch! 🚀

src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/ruby-in-gitpod.md Outdated Show resolved Hide resolved
Sean Hellum and others added 5 commits January 22, 2020 12:30
@jankeromnes jankeromnes merged commit 6dd8fbd into gitpod-io:master Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants