-
Notifications
You must be signed in to change notification settings - Fork 75
Conversation
eb993e1
to
dd8eb56
Compare
9f55e22
to
a27e72f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic PHP guide! Many thanks for writing it. 🙏
I've suggested a few minor improvements below.
Maybe also mention how to start debugging below your example repo? E.g.:
Also, there is something running on port 9000. I'm not sure what it is, but maybe you should Also, why open in the internal Debug console? I find it a bit confusing, as it randomly won't open automatically, causing you to miss all the debug output sometimes. I personally prefer my Debugger to use an actual Terminal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, many thanks! 🎉
Only a few small things. Please address them, and then feel free to merge this. 🙂
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for mentioning PECL
! I didn't know we had that already.
It seems to me that PHP extensions are normally installed via apt-get
(e.g. sudo apt-get install php-pgsql
, as we currently do in our base Dockerfile), but I don't see the harm in mentioning it's available if you like to use that.
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
Co-Authored-By: Jan Keromnes <[email protected]>
See #383