Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

[docs] PHP in Gitpod #418

Merged
merged 15 commits into from
Feb 12, 2020
Merged

[docs] PHP in Gitpod #418

merged 15 commits into from
Feb 12, 2020

Conversation

JesterOrNot
Copy link
Contributor

See #383

@JesterOrNot JesterOrNot changed the title [WIP] PHP in Gitpod PHP in Gitpod Jan 21, 2020
@JesterOrNot JesterOrNot changed the title PHP in Gitpod [docs] PHP in Gitpod Feb 5, 2020
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic PHP guide! Many thanks for writing it. 🙏

I've suggested a few minor improvements below.

src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
@jankeromnes
Copy link
Contributor

jankeromnes commented Feb 6, 2020

Maybe also mention how to start debugging below your example repo? E.g.:

Then simply open any .php file; open the Debug panel (crossed-out spider icon in the left vertical menu); and click on the green start button once. The debugger will automatically pause on the first line, allowing you to step through your code.

Also, there is something running on port 9000. I'm not sure what it is, but maybe you should onOpen: ignore it so that it doesn't open confusing notifications.

Also, why open in the internal Debug console? I find it a bit confusing, as it randomly won't open automatically, causing you to miss all the debug output sometimes. I personally prefer my Debugger to use an actual Terminal.

@JesterOrNot
Copy link
Contributor Author

I find the official console to be more versatile as you can specify verbosity levels
image

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, many thanks! 🎉

Only a few small things. Please address them, and then feel free to merge this. 🙂

src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
Sean Hellum and others added 6 commits February 7, 2020 11:37
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for mentioning PECL! I didn't know we had that already.

It seems to me that PHP extensions are normally installed via apt-get (e.g. sudo apt-get install php-pgsql, as we currently do in our base Dockerfile), but I don't see the harm in mentioning it's available if you like to use that.

src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
Sean Hellum and others added 4 commits February 12, 2020 09:36
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/php-in-gitpod.md Outdated Show resolved Hide resolved
Sean Hellum and others added 2 commits February 12, 2020 09:41
@JesterOrNot JesterOrNot merged commit bb7312c into gitpod-io:master Feb 12, 2020
@JesterOrNot JesterOrNot deleted the PHP branch February 12, 2020 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants