Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

[docs]: add JavaScript in Gitpod guide. #524

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

nisarhassan12
Copy link
Contributor

No description provided.

@JesterOrNot
Copy link
Contributor

see #383

@nisarhassan12
Copy link
Contributor Author

@nisarhassan12 nisarhassan12 force-pushed the javascript-in-gitpod branch 3 times, most recently from 9fb60ba to 2eeddd3 Compare May 13, 2020 00:57
@jankeromnes
Copy link
Contributor

Hey @nisarhassan12, what is the state of this PR? Are you still interested in working on it? 🙂

@nisarhassan12
Copy link
Contributor Author

Thanks! @jankeromnes I would like to finish this off in this week.

Copy link
Contributor

@JesterOrNot JesterOrNot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, a few things.

src/docs/javascript-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/javascript-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/javascript-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/javascript-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/javascript-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/javascript-in-gitpod.md Outdated Show resolved Hide resolved
src/docs/javascript-in-gitpod.md Outdated Show resolved Hide resolved
&& nvm use 8 \
&& nvm alias default 8"

RUN echo "nvm use default >/dev/null" >> /home/gitpod/.bashrc.d/51-nvm-fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, try

RUN echo "nvm use default &>/dev/null" >> ~/.bashrc.d/51-nvm-fix

This is a more compact easier to read notation. The &> will also redirect stderr.

And unless this version of bashrc is doing some sort of magic I'd maybe even change it to

RUN echo "nvm use default &>/dev/null" >> ~/.bashrc

src/docs/menu.ts Outdated Show resolved Hide resolved
src/docs/languages-and-frameworks.md Outdated Show resolved Hide resolved
Copy link
Contributor

@JesterOrNot JesterOrNot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A few more things I noticed.

src/docs/languages/javascript.md Outdated Show resolved Hide resolved
src/docs/languages/javascript.md Outdated Show resolved Hide resolved
src/docs/languages/javascript.md Outdated Show resolved Hide resolved
@nisarhassan12 nisarhassan12 changed the title WIP(don't merge) [docs]: add JavaScript in Gitpod guide. [docs]: add JavaScript in Gitpod guide. Jun 9, 2020
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, awesome, many many thanks @nisarhassan12 for writing a JavaScript guide! 💯

I'm super happy to see this happen, and the guide you wrote is good to go for me. A few optional suggestions in-line, but please feel free to merge this PR when you're happy with its state. 😄

src/docs/languages/javascript.md Outdated Show resolved Hide resolved
src/docs/languages/javascript.md Outdated Show resolved Hide resolved
src/docs/languages/javascript.md Outdated Show resolved Hide resolved
src/docs/languages/javascript.md Outdated Show resolved Hide resolved
src/docs/languages/javascript.md Outdated Show resolved Hide resolved
src/docs/languages/javascript.md Outdated Show resolved Hide resolved
Comment on lines 67 to 73
and then also add the following in .gitpod.yml:

```yaml
vscode:
extensions:
- [email protected]:/v3eRFwBI38JLZJv5ExY5g==
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to tell people to search for "eslint" in the IDE's extension panel, and to install it for their project, instead of asking them to add this "magic value" into their .gitpod.yml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this definitely makes more sense. Thanks

@nisarhassan12 nisarhassan12 merged commit a40c63a into master Aug 6, 2020
@nisarhassan12 nisarhassan12 deleted the javascript-in-gitpod branch August 6, 2020 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants