-
Notifications
You must be signed in to change notification settings - Fork 75
[docs]: add JavaScript in Gitpod guide. #524
Conversation
see #383 |
9fb60ba
to
2eeddd3
Compare
Hey @nisarhassan12, what is the state of this PR? Are you still interested in working on it? 🙂 |
Thanks! @jankeromnes I would like to finish this off in this week. |
2eeddd3
to
9d17e39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, a few things.
src/docs/javascript-in-gitpod.md
Outdated
&& nvm use 8 \ | ||
&& nvm alias default 8" | ||
|
||
RUN echo "nvm use default >/dev/null" >> /home/gitpod/.bashrc.d/51-nvm-fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead, try
RUN echo "nvm use default &>/dev/null" >> ~/.bashrc.d/51-nvm-fix
This is a more compact easier to read notation. The &>
will also redirect stderr.
And unless this version of bashrc is doing some sort of magic I'd maybe even change it to
RUN echo "nvm use default &>/dev/null" >> ~/.bashrc
9d17e39
to
9f1a6f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! A few more things I noticed.
9f1a6f5
to
c085855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, awesome, many many thanks @nisarhassan12 for writing a JavaScript guide! 💯
I'm super happy to see this happen, and the guide you wrote is good to go for me. A few optional suggestions in-line, but please feel free to merge this PR when you're happy with its state. 😄
src/docs/languages/javascript.md
Outdated
and then also add the following in .gitpod.yml: | ||
|
||
```yaml | ||
vscode: | ||
extensions: | ||
- [email protected]:/v3eRFwBI38JLZJv5ExY5g== | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's better to tell people to search for "eslint" in the IDE's extension panel, and to install it for their project, instead of asking them to add this "magic value" into their .gitpod.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this definitely makes more sense. Thanks
37ea50a
to
920e451
Compare
No description provided.