-
Notifications
You must be signed in to change notification settings - Fork 75
firebase: init #645
base: master
Are you sure you want to change the base?
firebase: init #645
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,13 @@ | ||||||||||
![](https://raw.githubusercontent.com/gitpod-io/firebase-on-gitpod/master/img/firebase-on-gitpod-header.png) | ||||||||||
|
||||||||||
# Firebase on Gitpod | ||||||||||
|
||||||||||
Firebase is a platform owned by Google which is used to develop mobile and web applications | ||||||||||
|
||||||||||
[![Open proof-of-concept in gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io#snapshot/45abf388-128e-4cce-b336-20ba69288d84) | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please explain what this button does, e.g. by adding an intro sentence like:
Suggested change
|
||||||||||
|
||||||||||
### Configuring the access token | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Before this section, I think it would be cool to explain how one can install Firebase in Gitpod. E.g. assume that the reader is relatively new to Gitpod -- the Scala section is a great example of how to achieve this: https://www.gitpod.io/docs/languages/scala/#installing-scala |
||||||||||
|
||||||||||
![Theia (Gitpod's editor)](https://github.com/eclipse-theia/theia) is as of 18/05/2020 using `iframe` to display pages in it's preview which is not allowed on some Google websites (https://github.com/gitpod-io/gitpod/issues/1528) and so firebase on gitpod requires the end-user to be logged-in using a hyperlink generated from `firebase login --no-localhost` and it's token stored as environmental variable `FIREBASE_TOKEN` in https://gitpod.io/settings to avoid parsing `firebase subcommand --token YOUR_TOKEN` for every command. | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Theia is not really an editor, but a full IDE:
Suggested change
|
||||||||||
|
||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -145,6 +145,10 @@ export const MENU: MenuEntry[] = [ | |
"Julia", | ||
"languages/julia" | ||
), | ||
M( | ||
"Firebase", | ||
"frameworks/firebase" | ||
), | ||
Comment on lines
+148
to
+151
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This contribution raises interesting questions about the "Languages & Frameworks" section.
I still find it confusing to mix frameworks with languages, but we also can't merge Firebase into an existing language guide. Maybe we should indeed have separate "Languages" and "Frameworks" sub-menus? Also, Firebase isn't even a "framework". Maybe it's more like a "tool", or "technology"? (Same goes for databases and such). So maybe let's have "Languages" and "Tools" sub-menus? |
||
M( | ||
"LaTeX", | ||
"languages/latex" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an alt image description, e.g.:
However, since none of the other guides have a header, maybe having one here isn't necessary.