Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

add browser extension flow pages. #835

Merged
merged 4 commits into from
Jan 25, 2021
Merged

add browser extension flow pages. #835

merged 4 commits into from
Jan 25, 2021

Conversation

nisarhassan12
Copy link
Contributor

@nisarhassan12 nisarhassan12 commented Nov 17, 2020 •
edited
Loading

No description provided.

@nisarhassan12 nisarhassan12 force-pushed the browser-extension-flow branch 2 times, most recently from 9d679a5 to 31d62e4 Compare November 19, 2020 13:24
@nisarhassan12 nisarhassan12 force-pushed the browser-extension-flow branch 9 times, most recently from 8b6cabd to 4ea5b6a Compare December 1, 2020 15:27
@nisarhassan12 nisarhassan12 marked this pull request as ready for review December 1, 2020 15:58
@chrifro
Copy link
Contributor

chrifro commented Dec 9, 2020 •
edited by nisarhassan12
Loading

Thanks, @nisarhassan12

Here are a few comments

Activation page:

  • the screenshot seems blurry, please use the attached file
    Github-gitpod-button

  • there should be no reinstall extensionbutton on the activation page

Uninstall page:

  • the text in the button reinstall extension is not centered. Please align it

  • reinstall extensionshould link to the correlated Chrome or Firefox extension

  • The URL /extension-uninstall fits better than /extension-deletion

  • sending the form should also be allowed when using the text field

Would be great to connect the user feedback to our data bank. Where is the feedback currently send to? I'll discuss that with Johannes as well

@nisarhassan12
Copy link
Contributor Author

the text in the button reinstall extension is not centered. Please align it

Thanks. @ChristinFrohne for the feedback. I'm unable to re-produce this. Can you share zoomed-in screenshots of this issue ? The button has the same amounts of paddings for the left/right and the top/bottom to give the centered look to the text inside.

image

@nisarhassan12 nisarhassan12 force-pushed the browser-extension-flow branch 3 times, most recently from d109dbe to e78c9cb Compare December 20, 2020 07:28
@nisarhassan12
Copy link
Contributor Author

Would be great to connect the user feedback to our data bank. Where is the feedback currently send to? I'll discuss that with Johannes as well

The feedback is sent to the place where the data for other contacts forms is sent. I don't have access to that place. Someone with access to that place should test whether the data gets submitted correctly or not.

@nisarhassan12
Copy link
Contributor Author

@ChristinFrohne I changed the minimal Footer to have the mention of Gitpod as opposed to TypeFox like we recently did for the main primary Footer.

@chrifro
Copy link
Contributor

chrifro commented Dec 28, 2020

Thanks for fixing the outstanding issues

I'm unable to re-produce this. Can you share zoomed-in screenshots of this issue ?

It's a minor issue, but it seems that the text box has more spacing below the text than above. Or is it because there are no descending letters?
Bildschirmfoto 2020-12-28 um 14 33 48

@chrifro
Copy link
Contributor

chrifro commented Dec 28, 2020 •
edited
Loading

@gtsiolis you suggested duplicating the GitLab, GitHub and Bitbucket buttons above the screenshot. Are you fine creating the first version like this and iterating on it afterwards? Otherwise, please add your suggestion to the PR.

@chrifro
Copy link
Contributor

chrifro commented Dec 28, 2020

What would be the best way to collect the user feedback? @JohannesLandgraf @jankeromnes
Can we connect it directly to our data bank?
I just sent a test feedback, but I couldn't find it anywhere.

Bildschirmfoto 2020-12-28 um 15 00 17

@nisarhassan12
Copy link
Contributor Author

nisarhassan12 commented Dec 30, 2020 •
edited
Loading

It's a minor issue, but it seems that the text box has more spacing below the text than above. Or is it because there are no descending letters?

@ChristinFrohne You are right it's because there are no descenders. I just tried adding one it looks perfectly centred to me.

image

@nisarhassan12 nisarhassan12 mentioned this pull request Jan 19, 2021
Closed
@nisarhassan12
Copy link
Contributor Author

@ChristinFrohne for figuring out where the data submited on /extension-uninstall goes let's maybe merge this PR without publicly mentioning or linking to the pages that it adds anywhere ? I think the data will go to the same place as is the case for other forms in production.

@chrifro
Copy link
Contributor

chrifro commented Jan 25, 2021

Sounds good, let's merge and test it.

@nisarhassan12 nisarhassan12 merged commit 06657aa into master Jan 25, 2021
@nisarhassan12 nisarhassan12 deleted the browser-extension-flow branch January 25, 2021 15:07
nisarhassan12 added a commit that referenced this pull request Jan 25, 2021
@nisarhassan12
add browser extension flow pages. (#835)
ec896c4 
* update get started section.

Fixes gitpod-io/website#819

* add browser extension flow pages.

* exclude the extension uninstall page from the build.

* small fixes.
nisarhassan12 added a commit that referenced this pull request Jan 25, 2021
@nisarhassan12
add browser extension flow pages. (#835)
d36ebf9 
* update get started section.

Fixes gitpod-io/website#819

* add browser extension flow pages.

* exclude the extension uninstall page from the build.

* small fixes.
@nisarhassan12 nisarhassan12 mentioned this pull request Jan 25, 2021
Merged
@mikenikles
Copy link
Contributor

@nisarhassan12 & @ChristinFrohne do you recall testing the form submission for the "uninstall browser extension" page? I don't see any emails that match.

I worked on the migration of this page to the new website today and noticed the form doesn't get submitted. This is also the case on the current production site. I'll look into it to see what may cause it.

@mikenikles
Copy link
Contributor

That was quicker than expected... The email in this PR is missing from information, hence users cannot submit the form successfully. A fix is applied to the new website.

@chrifro
Copy link
Contributor

chrifro commented Apr 6, 2021

For more information see #1009

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gtsiolis gtsiolis Awaiting requested review from gtsiolis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nisarhassan12 @chrifro @mikenikles