-
Notifications
You must be signed in to change notification settings - Fork 75
[SEO]: fix page not found(external links). #864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @nisarhassan12!
The client.sh
script shown in the screenshot has moved in Chocobozzz/PeerTube@c026a2e#diff-f170b9f2b1dbb022fc6aa6f450eb06693d96ab14ddd2711d75585ad4e2bd3751 to /scripts/dev/client.sh
.
suggestion: We can update the link to point to the new path or even better link using the permalink to a specific commit to avoid introducing such broken links in the future.
/cc @jankeromnes because https://github.com/gitpod-io/website/pull/142
@@ -134,7 +134,7 @@ Refer to the links below to add your own functionalities. | |||
|
|||
## Links to Refer | |||
* If you would like to learn more about the actions-on-google library, you can find it here - https://www.npmjs.com/package/actions-on-google | |||
* Go through these examples - https://developers.google.com/actions/samples/github | |||
* Go through these examples - https://developers.google.com/assistant/conversational/df-asdk/samples/github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds accurate!
What is the status here @nisarhassan12 ? |
Sorry I have not made the remaining changes yet. Will hopefully make them soon and then merge it. |
Great, thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this as-is now as it resolves a broken link. George your feedback about client.sh
has been lifted over to https://github.com/gitpod-io/website/issues/842#issuecomment-799868269
will address the following from #842 :