Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

[SEO]: fix page not found(external links). #864

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

nisarhassan12
Copy link
Contributor

will address the following from #842 :

image

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @nisarhassan12!

The client.sh script shown in the screenshot has moved in Chocobozzz/PeerTube@c026a2e#diff-f170b9f2b1dbb022fc6aa6f450eb06693d96ab14ddd2711d75585ad4e2bd3751 to /scripts/dev/client.sh.

suggestion: We can update the link to point to the new path or even better link using the permalink to a specific commit to avoid introducing such broken links in the future.

/cc @jankeromnes because https://github.com/gitpod-io/website/pull/142

@@ -134,7 +134,7 @@ Refer to the links below to add your own functionalities.

## Links to Refer
* If you would like to learn more about the actions-on-google library, you can find it here - https://www.npmjs.com/package/actions-on-google
* Go through these examples - https://developers.google.com/actions/samples/github
* Go through these examples - https://developers.google.com/assistant/conversational/df-asdk/samples/github
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds accurate!

@chrifro
Copy link
Contributor

chrifro commented Jan 5, 2021

What is the status here @nisarhassan12 ?

@nisarhassan12
Copy link
Contributor Author

Sorry I have not made the remaining changes yet. Will hopefully make them soon and then merge it.

@chrifro
Copy link
Contributor

chrifro commented Jan 5, 2021

Great, thanks :)

@ghuntley ghuntley mentioned this pull request Mar 16, 2021
35 tasks
@ghuntley ghuntley marked this pull request as ready for review March 16, 2021 01:13
Copy link
Contributor

@ghuntley ghuntley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this as-is now as it resolves a broken link. George your feedback about client.sh has been lifted over to https://github.com/gitpod-io/website/issues/842#issuecomment-799868269

@ghuntley ghuntley merged commit 7360fc7 into master Mar 16, 2021
@ghuntley ghuntley deleted the not-found-external-links branch March 16, 2021 01:14
@ghuntley ghuntley added the SEO label Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants