Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

fix headlines order for better accessibility and seo. #917

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

nisarhassan12
Copy link
Contributor

@nisarhassan12 nisarhassan12 commented Dec 26, 2020

Addresses the following from #842

image

Why this is important:

According to https://www.w3.org/WAI/tutorials/page-structure/headings/

image

@nisarhassan12 nisarhassan12 force-pushed the fix-headlines-orders branch 11 times, most recently from 8d33544 to acc9692 Compare December 28, 2020 16:45
@nisarhassan12 nisarhassan12 marked this pull request as ready for review December 28, 2020 16:47
@nisarhassan12
Copy link
Contributor Author

nisarhassan12 commented Dec 28, 2020

I have corrected the order of the headings for all the pages of the site including the docs. On the blog, the heading order still needs to be corrected. @ChristinFrohne @JohannesLandgraf Can I change the order of the headings in the blog posts as well? Or do I have to check with the authors of the individual blog posts first? Thanks

@chrifro
Copy link
Contributor

chrifro commented Jan 4, 2021

Thanks @nisarhassan12
Looks good. It's fine if you change the headline style without asking the author of each blog post. Your changes won't influence the content, so it's fine.

@nisarhassan12 nisarhassan12 force-pushed the fix-headlines-orders branch 2 times, most recently from 4c78355 to 1f28a4e Compare January 5, 2021 12:07
@nisarhassan12
Copy link
Contributor Author

@ChristinFrohne I have made the changes to the blog posts as well. Please have a look again when you'll have time. Thanks

Copy link
Contributor

@chrifro chrifro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@nisarhassan12
Copy link
Contributor Author

Thanks, @ChristinFrohne for the review. I'll merge this after doing a final self-review to see if there aren't any pages that are leftout.

@chrifro chrifro mentioned this pull request Jan 5, 2021
35 tasks
@nisarhassan12 nisarhassan12 merged commit 49c7da9 into master Jan 5, 2021
@nisarhassan12 nisarhassan12 deleted the fix-headlines-orders branch January 5, 2021 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants