Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

make site valid in accordance to W3C validator. #932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nisarhassan12
Copy link
Contributor

@nisarhassan12 nisarhassan12 commented Jan 5, 2021

Fixes #868
Addresses the following from gitpod-io/website#842

image

@nisarhassan12 nisarhassan12 marked this pull request as draft January 5, 2021 14:02
@nisarhassan12 nisarhassan12 mentioned this pull request Jan 5, 2021
35 tasks
@nisarhassan12 nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch 3 times, most recently from 786452f to 608f0a6 Compare January 5, 2021 16:27
@nisarhassan12
Copy link
Contributor Author

nisarhassan12 commented Jan 5, 2021

Not sure How we can get rid of these errors will look it up later:

image

image

Todo

I will inspect later how these can be addressed.

/pricing

image

image

I'm done testing most of the pages apart from /docs, individual blog post and Imprint, ToS, Privacy Policy.

@nisarhassan12 nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch 2 times, most recently from 5df1a08 to 9d3a5ab Compare January 5, 2021 17:47
@nisarhassan12
Copy link
Contributor Author

nisarhassan12 commented Jan 5, 2021

According to W3C we should avoid nesting Links:

image

But currently, we're doing it on https://www.gitpod.io/blog in the PostPreview Card

image

Removing the links from the author name would fix this issue. @ChristinFrohne Is this ok to remove the links from the names? Thanks

image

EDIT

The issue is quite critical that it caused the other errors to be ignored.

@nisarhassan12 nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch from 9d3a5ab to d2519a9 Compare January 5, 2021 18:46
@chrifro
Copy link
Contributor

chrifro commented Jan 7, 2021

@nisarhassan12 I just noticed that the links to the author's profile are not working anyways. So you can just remove the link completely from the overview page. On each blog post the link to the author's profile needs to be there though.

@nisarhassan12 nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch from d2519a9 to b96ebcf Compare January 7, 2021 09:10
@nisarhassan12 nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch 3 times, most recently from 835f452 to 9f47a41 Compare January 18, 2021 15:57
@nisarhassan12 nisarhassan12 force-pushed the nisarhassan12/seo-improvements-842 branch from 9f47a41 to 3ee3d1d Compare January 18, 2021 16:00
@nisarhassan12 nisarhassan12 marked this pull request as ready for review January 18, 2021 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate the entire site with w3c validator and fix the issues for better SEO results.
2 participants