Autofix GitHub Action #1202
Merged
Autofix GitHub Action #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
reviewed
Oct 13, 2023
.github/workflows/autofix.yml
Outdated
|
|
||
| - name: Run autofix | ||
| run: | | ||
| npm -g autofix |
There was a problem hiding this comment.
nit: would be cool to tie versions here somehow, so we have at least some amount of control over what code we pass our GITHUB_TOKEN to... 😕 Can we maybe hard-code a specific version of autofix at least?
But I guess we are already doing this somewhere else, and this is merely a better way to execute it, so partly out of scope here. 😕
There was a problem hiding this comment.
@geropl thanks for pointing this out! I will keep Autofix updated and have now pinned the version to the latest one 🙏
geropl
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR runs Autofix inside a GitHub Action, which results in us having more control over how it runs. Specifically, the Pull Requests raised will actually result from branches inside the repository, meaning that CI will be happy and automated tests will run correctly.
Related Issue(s)
Fixes EXP-486