Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to llvm 18 #1375

Closed
wants to merge 4 commits into from
Closed

feat: upgrade to llvm 18 #1375

wants to merge 4 commits into from

Conversation

gengjiawen
Copy link
Contributor

@gengjiawen gengjiawen commented Jun 24, 2024 •
edited
Loading

#fix #1360

verified by npx envinfo

  Utilities:
    Make: 4.3 - /usr/bin/make
    GCC: 11.4.0 - /usr/bin/gcc
    Git: 2.43.2 - /usr/bin/git
    Clang: 18.1.8 - /usr/bin/clang

two new packages was added for the asan support.

@gengjiawen gengjiawen requested review from a team as code owners June 24, 2024 12:37
@gengjiawen
Copy link
Contributor Author

cc @filiptronicek

@gengjiawen
Copy link
Contributor Author

friendly ping @filiptronicek

@kylos101
Copy link
Collaborator

kylos101 commented Jul 1, 2024

👋 @gengjiawen can I trouble you to update https://github.com/gitpod-io/workspace-images/blob/main/CHANGELOG.md in this PR, too?

Also, it seems our CI won't run on forks. So, I'll open a branch in our org/repo and set you as a co-author.

I checked, and updating from 17 to 18 doesn't seem to be breaking. 👍

@kylos101 kylos101 mentioned this pull request Jul 2, 2024
Merged
@kylos101
Copy link
Collaborator

kylos101 commented Jul 2, 2024

Closing in favor of #1377 (our private runners will not run in your fork).

@kylos101 kylos101 closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update to llvm 18
2 participants
@gengjiawen @kylos101