Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 and introduce Python 3.13 #1443

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

filiptronicek
Copy link
Member

Description

What the title says. Python 3.8 reached EoL on October 7th and hence we don't have to push any new versions of it. On the same date, the new Python minor (3.13) was introduced.

@filiptronicek filiptronicek requested review from a team as code owners October 22, 2024 08:50
@@ -17,12 +17,11 @@
workspace-node-18: "TIMESTAMP_TAG"
workspace-node-20: "TIMESTAMP_TAG"
workspace-node-22: "TIMESTAMP_TAG"
workspace-python: "TIMESTAMP_TAG"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to remove workspace-python? (I thought images without specified versions will point to latest stable)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustard-mh that's what we do for other images like workspace-node indeed, but we have not actually been updating it since last August, so this is just a cleanup. We can re-introduce it in the dazzle.yaml in a follow-up if we need to, but this is just syncing what we build to what we push.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustard-mh that's what we do for other images like workspace-node indeed

From README.md, we still have workspace-node, it's not removed.

Btw, workspace-python is documented in our docs as well (after this PR, we'll not maintain it anymore but users with this image configured don't know it
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustard-mh we still have and update workspace-node and we always have. workspace-python will continue to work, but be stuck on the last version we pushed it to last year (this PR does not change that, it has been like this since we merged that PR I mentioned above). What I'm saying is: let's introduce workspace-python again in a subsequent PR, but as of writing, it's outdated, and it does not need to be updated every time we push to our container registries, because we don't build it.

@filiptronicek filiptronicek merged commit ea78e05 into main Oct 23, 2024
4 checks passed
@filiptronicek filiptronicek deleted the ft/pythonic-updates branch October 23, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants