-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Java 23 #1457
✨ Add Java 23 #1457
Conversation
@jeanphi-baconnais thanks for the contribution! I think it makes sense to have Java's latest around. We're going to need to create a new image for it though to be in line with what we have for all other languages. |
Hello @filiptronicek , I add a commit on the dazzle.file and a file test. Tell me if this looks good for you. |
@jeanphi-baconnais thanks for the update! I have taken a look and made sure that we also properly synchronize the resulting image to our GCR and have it listed in the README. I have also reverted the changes to other images besides the newly-introduced ones, because we're keeping Java 11 there for compatibility reasons: a big percentage of the ecosystem still uses it, compared to the negligible percentage of folks using the latest release (for instance, according to the New Relic, Java 21 is used in only 1.4% of monitored projects in 20241). Footnotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you again! 🧡
Hello @filiptronicek ,
oh sorry, I think updating all images was a good option 😅 Thanks for accepting this PR 🙏 |
Description
I propose this PR to add Java 23 chunk.
Related Issue(s)
Fixes no issue created for this PR
How to test
Documentation
Does this PR require updates to the documentation at www.gitpod.io/docs?