Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Java 23 #1457

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Conversation

jeanphi-baconnais
Copy link
Contributor

Description

I propose this PR to add Java 23 chunk.

Related Issue(s)

Fixes no issue created for this PR

How to test

Documentation

Does this PR require updates to the documentation at www.gitpod.io/docs?

  • No

@filiptronicek
Copy link
Member

@jeanphi-baconnais thanks for the contribution! I think it makes sense to have Java's latest around. We're going to need to create a new image for it though to be in line with what we have for all other languages.
Feel free to add it yourself in the dazzle.yaml, or I can help you with it end of this week or early next week.

@jeanphi-baconnais jeanphi-baconnais requested a review from a team as a code owner November 6, 2024 10:52
@jeanphi-baconnais
Copy link
Contributor Author

Hello @filiptronicek , I add a commit on the dazzle.file and a file test. Tell me if this looks good for you.
The command ./build-all.sh is ok 😄

@filiptronicek
Copy link
Member

@jeanphi-baconnais thanks for the update! I have taken a look and made sure that we also properly synchronize the resulting image to our GCR and have it listed in the README.

I have also reverted the changes to other images besides the newly-introduced ones, because we're keeping Java 11 there for compatibility reasons: a big percentage of the ecosystem still uses it, compared to the negligible percentage of folks using the latest release (for instance, according to the New Relic, Java 21 is used in only 1.4% of monitored projects in 20241).

Footnotes

  1. https://newrelic.com/resources/report/2024-state-of-the-java-ecosystem#new-java-versions-being-adopted-faster

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you again! 🧡

@filiptronicek filiptronicek enabled auto-merge (squash) November 11, 2024 13:36
@filiptronicek filiptronicek merged commit 0bfa610 into gitpod-io:main Nov 11, 2024
2 of 4 checks passed
@jeanphi-baconnais
Copy link
Contributor Author

Hello @filiptronicek ,

I have also reverted the changes to other images besides the newly-introduced ones, because we're keeping Java 11 there for compatibility reasons: a big percentage of the ecosystem still uses it, compared to the negligible percentage of folks using the latest release (for instance, according to the New Relic, Java 21 is used in only 1.4% of monitored projects in 20241).

oh sorry, I think updating all images was a good option 😅

Thanks for accepting this PR 🙏

@jeanphi-baconnais jeanphi-baconnais deleted the feature/add-java-23 branch November 11, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants