Skip to content

Commit

Permalink
Add missing raises keyword for test_depth xfail
Browse files Browse the repository at this point in the history
I had forgotten to do this earlier when converting from skip to
xfail. Besides consistency with the other uses of xfail in the test
suite, the benefit of passing "raises" is that pytest checks that
the failure gave the expected exception and makes it a non-expected
failure if it didn't.
  • Loading branch information
EliahKagan committed Sep 25, 2023
1 parent 1d6abdc commit 5609faa
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/test_submodule.py
Original file line number Diff line number Diff line change
Expand Up @@ -1049,6 +1049,7 @@ class Repo(object):

@pytest.mark.xfail(
reason="for some unknown reason the assertion fails, even though it in fact is working in more common setup",
raises=AssertionError,
)
@with_rw_directory
def test_depth(self, rwdir):
Expand Down

0 comments on commit 5609faa

Please sign in to comment.