Skip to content

Commit

Permalink
Use Alpine Linux in WSL on CI
Browse files Browse the repository at this point in the history
Some of the CI tests use WSL. This switches the WSL distribution
from Debian to Alpine, which might be slightly faster. For the way
it is being used here, the main expected speed improvement would be
to how long the image would take to download, as Alpine is smaller.

(The reason for this is thus unrelated to the reason for the Alpine
docker CI test job added in #1826. There, the goal was to test on a
wider variety of systems and environments, and that runs the whole
test suite in Alpine. This just changes the WSL distro, used by a
few tests on Windows, from Debian to Alpine.)

Two things have changed that, taken together, have unblocked this:

- Vampire/setup-wsl#50 was fixed, so the
  action we are using is able to install Alpine Linux. See:
  #1917 (review)

- #1893 was fixed in #1888. So if switching the WSL distro from
  Debian to Alpine breaks any tests, including by making them fail
  in an unexpected way that raises the wrong exception, we are
  likely to find out.
  • Loading branch information
EliahKagan committed Jul 24, 2024
1 parent ea583e1 commit 58a9a58
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
if: startsWith(matrix.os, 'windows')
uses: Vampire/[email protected]
with:
distribution: Debian
distribution: Alpine

- name: Prepare this repo for tests
run: |
Expand Down

0 comments on commit 58a9a58

Please sign in to comment.