Skip to content

Commit

Permalink
Let close_fds be True on all platforms
Browse files Browse the repository at this point in the history
Since Python 3.7, subprocess.Popen supports close_fds=True on all
platforms, including Windows, and it is the default, including
when arguments for standard streams have non-None values passed.
3.7 is the lowest version of Python that GitPython supports. So
this omits the close_fds=True argument from the calls where it was
present. This has the same effect (in 3.7 and higher) as passing
close_fds=True.

When the the close_fd argument was added to the Popen call in
git.cmd.Git.execute in 1ee2afb, Python 2 was still supported. In
Python 2, close_fds defaulted to False. This appears to be the
reason it had been passed explicitly. It was conditioned on being
on a Unix-like system because having it True on Windows would
prevent stdin, stdout, or stderr redirection.
  • Loading branch information
EliahKagan committed Dec 1, 2023
1 parent 96acc22 commit 78d63d9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion git/cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,6 @@ def execute(
stderr=PIPE,
stdout=stdout_sink,
shell=shell,
close_fds=(os.name == "posix"), # Unsupported on Windows.
universal_newlines=universal_newlines,
creationflags=PROC_CREATIONFLAGS,
**subprocess_kwargs,
Expand Down
1 change: 0 additions & 1 deletion git/index/fun.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ def run_commit_hook(name: str, index: "IndexFile", *args: str) -> None:
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
cwd=index.repo.working_dir,
close_fds=(os.name == "posix"),
creationflags=PROC_CREATIONFLAGS,
)
except Exception as ex:
Expand Down

0 comments on commit 78d63d9

Please sign in to comment.