Skip to content

Commit

Permalink
Use venv instead of virtualenv in test_installation
Browse files Browse the repository at this point in the history
This eliminates the test dependency on virtualenv by using the
standard library venv module instead in test_installation.
  • Loading branch information
EliahKagan committed Sep 17, 2023
1 parent e8c3085 commit ad76c99
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 0 additions & 1 deletion test-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ pre-commit
pytest
pytest-cov
pytest-sugar
virtualenv
4 changes: 3 additions & 1 deletion test/test_installation.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import ast
import os
import subprocess
import sys

from git.compat import is_win
from test.lib import TestBase
from test.lib.helper import with_rw_directory
Expand All @@ -12,7 +14,7 @@
class TestInstallation(TestBase):
def setUp_venv(self, rw_dir):
self.venv = rw_dir
subprocess.run(["virtualenv", self.venv], stdout=subprocess.PIPE)
subprocess.run([sys.executable, "-m", "venv", self.venv], stdout=subprocess.PIPE)
bin_name = "Scripts" if is_win else "bin"
self.python = os.path.join(self.venv, bin_name, "python")
self.pip = os.path.join(self.venv, bin_name, "pip")
Expand Down

0 comments on commit ad76c99

Please sign in to comment.