Merge pull request #1788 from EliahKagan/void-finalizer

In handle_process_output don't forward finalizer result
gitpython-developers · Dec 26, 2023 · b2c46f7 · b2c46f7
2 parents 597e1a6 + 7057b9b
commit b2c46f7
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/git/cmd.py b/git/cmd.py
@@ -111,7 +111,6 @@ def handle_process_output(
 
     This function returns once the finalizer returns.
 
-    :return: Result of finalizer
     :param process: :class:`subprocess.Popen` instance
     :param stdout_handler: f(stdout_line_string), or None
     :param stderr_handler: f(stderr_line_string), or None
@@ -205,9 +204,7 @@ def pump_stream(
                 stderr_handler(error_str)  # type: ignore
 
     if finalizer:
-        return finalizer(process)
-    else:
-        return None
+        finalizer(process)
 
 
 def dashify(string: str) -> str: