Skip to content

Commit

Permalink
Remove TestSubmodule.test_rename xfail mark
Browse files Browse the repository at this point in the history
This is to clearly establish the failure still occurs (since we do
not have strict=True set). It is in preparation for working around
the problems with a call to gc.collect().

See 82c361e and 0b7ee17 for context.
  • Loading branch information
EliahKagan committed Dec 12, 2023
1 parent 0fa0047 commit f62df52
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions test/test_submodule.py
Original file line number Diff line number Diff line change
Expand Up @@ -948,18 +948,6 @@ def test_remove_norefs(self, rwdir):
sm.remove()
assert not sm.exists()

@pytest.mark.xfail(
os.name == "nt" and sys.version_info >= (3, 12),
reason=(
"The sm.move call fails. Submodule.move calls os.renames, which raises:\n"
"PermissionError: [WinError 32] "
"The process cannot access the file because it is being used by another process: "
R"'C:\Users\ek\AppData\Local\Temp\test_renamekkbznwjp\parent\mymodules\myname' "
R"-> 'C:\Users\ek\AppData\Local\Temp\test_renamekkbznwjp\parent\renamed\myname'"
"\nThis resembles other Windows errors, but only occurs starting in Python 3.12."
),
raises=PermissionError,
)
@with_rw_directory
def test_rename(self, rwdir):
parent = git.Repo.init(osp.join(rwdir, "parent"))
Expand Down

0 comments on commit f62df52

Please sign in to comment.