Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #1655

Closed
wants to merge 1 commit into from
Closed

Conversation

owenwu811
Copy link

No description provided.

@Byron
Copy link
Member

Byron commented Sep 12, 2023

Thanks for contributing, even though I don't quite understand what the purpose of this PR is.

The reason I am closing it is that I just merged a huge PR that affects setup.py. Please review what's there now and chances are this change here won't be needed anymore. If that's not the case, please open a new PR with the changes you need, while not hesitating to spell out what it does, for dummies, if you will :). Thanks.

@Byron Byron closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants