Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In handle_process_output don't forward finalizer result #1788

Merged
merged 1 commit into from
Dec 26, 2023
Merged

In handle_process_output don't forward finalizer result #1788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions git/cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ def handle_process_output(

This function returns once the finalizer returns.

:return: Result of finalizer
:param process: :class:`subprocess.Popen` instance
:param stdout_handler: f(stdout_line_string), or None
:param stderr_handler: f(stderr_line_string), or None
Expand Down Expand Up @@ -205,9 +204,7 @@ def pump_stream(
stderr_handler(error_str) # type: ignore

if finalizer:
return finalizer(process)
else:
return None
finalizer(process)


def dashify(string: str) -> str:
Expand Down
Loading