Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: switch order Ruff's hooks fix -> format #1912

Merged
merged 1 commit into from
May 7, 2024

Conversation

Borda
Copy link
Contributor

@Borda Borda commented May 7, 2024

Since fix may do some additional changes, it makes sense to first run fixing and the formatting so you may need to run pre-commit only once in case fixing wont be compatible with formatting

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that sounds very reasonable.
Updating the version of ruff at the same time seems like a win, too.

@Byron Byron merged commit cd490f8 into gitpython-developers:main May 7, 2024
26 checks passed
@Borda Borda deleted the lint/ruff branch May 7, 2024 19:28
@Borda
Copy link
Contributor Author

Borda commented May 7, 2024

@Byron, btw, how about installing this bot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants