Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OSS-Fuzz Scripts to Use New QA-Assets Repo Structure #1913

Conversation

DaveLak
Copy link
Contributor

@DaveLak DaveLak commented May 8, 2024

merging gitpython-developers/qa-assets#2 should be coordinated with merging this PR.

This change is required to support the changes to the seed data repo structure introduced in:
gitpython-developers/qa-assets#2

This moves most of the seed data related build steps into the OSS-Fuzz Docker image build via container-environment-bootstrap.sh. This includes moveing the dictionaries into that repo.

The fuzzing/README.md here should be updated in a follow-up with a link to the qa-assets repo (and probably some context setting about corpora in general) but I have opted to defer that as I think the functionality added by the seed data improvements is valuable as is and shouldn't be blocked by documentation writers block.

This change is required to support the changes to the seed data repo
structure introduced in:
gitpython-developers/qa-assets#2

This moves most of the seed data related build steps into the OSS-Fuzz
Docker image build via `container-environment-bootstrap.sh`. This
includes moveing the dictionaries into that repo.

The fuzzing/README.md here should be updated in a follow-up with a link
to the qa-assets repo (and probably some context setting about corpora
in general) but I have opted to defer that as I think the functionality
added by the seed data improvements is valuable as is and shouldn't be
blocked by documentation writers block.
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for driving fuzzing forward, relentlessly!

I will set this to auto-merge so when done, you could merge the PR in qa-assets yourself.

@DaveLak
Copy link
Contributor Author

DaveLak commented May 8, 2024

Thanks a lot for driving fuzzing forward, relentlessly!

Thanks for letting me! I've still got my eyes on gitoxide fuzzing, so don't worry 😄

I will set this to auto-merge so when done, you could merge the PR in qa-assets yourself.

Thanks! Will do.

@Byron
Copy link
Member

Byron commented May 8, 2024

It turns out there is no auto-merging for me, so I will just merge both myself when I get back.

@Byron Byron merged commit a5815b6 into gitpython-developers:main May 8, 2024
51 checks passed
@DaveLak DaveLak deleted the refactor-oss-fuzz-scripts-to-use-new-qa-assets-repo-layout branch May 8, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants