Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base.py #1965

Merged
merged 5 commits into from
Oct 5, 2024
Merged

Conversation

alex20230721
Copy link
Contributor

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bare repositories are typically cloned with the .git extension, hence the example is representing something that is common. There is no point in trying to make it work for a non-bare clone.

However, you could add another line that shows that one can also point at the .git directory that is typically sitting in a worktree.

@alex20230721
Copy link
Contributor Author

Bare repositories are typically cloned with the .git extension, hence the example is representing something that is common. There is no point in trying to make it work for a non-bare clone.

However, you could add another line that shows that one can also point at the .git directory that is typically sitting in a worktree.

Sorry, I just learned about the concept of bare repo today.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, let me see if I can finalize this PR now.

git/repo/base.py Outdated Show resolved Hide resolved
@Byron Byron merged commit 49ca909 into gitpython-developers:main Oct 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants