Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated plot to make use of data minimum for setting up plot Y axis #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions v3/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,22 @@ func GetMaxFloat64From2dSlice(slices [][]float64) (float64, error) {
return max, nil
}

func GetMinFloat64From2dSlice(slices [][]float64) (float64, error) {
if len(slices) == 0 {
return 0, fmt.Errorf("cannot get max value from empty slice")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot get max value from empty slice -> cannot get min value from empty slice

}
var min float64
min = slices[0][0]
for _, slice := range slices {
for _, val := range slice {
if val < min {
min = val
}
}
}
return min, nil
}

func RoundFloat64(x float64) float64 {
return math.Floor(x + 0.5)
}
Expand Down
26 changes: 16 additions & 10 deletions v3/widgets/plot.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type Plot struct {

Data [][]float64
DataLabels []string
MinVal float64
MaxVal float64

LineColors []Color
Expand Down Expand Up @@ -76,7 +77,7 @@ func NewPlot() *Plot {
}
}

func (self *Plot) renderBraille(buf *Buffer, drawArea image.Rectangle, maxVal float64) {
func (self *Plot) renderBraille(buf *Buffer, drawArea image.Rectangle, minVal float64, maxVal float64) {
Copy link

@iamquang95 iamquang95 Feb 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed implementation of this part

canvas := NewCanvas()
canvas.Rectangle = drawArea

Expand Down Expand Up @@ -118,12 +119,13 @@ func (self *Plot) renderBraille(buf *Buffer, drawArea image.Rectangle, maxVal fl
canvas.Draw(buf)
}

func (self *Plot) renderDot(buf *Buffer, drawArea image.Rectangle, maxVal float64) {
func (self *Plot) renderDot(buf *Buffer, drawArea image.Rectangle, minVal float64, maxVal float64) {
r := maxVal - minVal
switch self.PlotType {
case ScatterPlot:
for i, line := range self.Data {
for j, val := range line {
height := int((val / maxVal) * float64(drawArea.Dy()-1))
height := int(((val - minVal) / r) * float64(drawArea.Dy()-1))
point := image.Pt(drawArea.Min.X+(j*self.HorizontalScale), drawArea.Max.Y-1-height)
if point.In(drawArea) {
buf.SetCell(
Expand All @@ -137,7 +139,7 @@ func (self *Plot) renderDot(buf *Buffer, drawArea image.Rectangle, maxVal float6
for i, line := range self.Data {
for j := 0; j < len(line) && j*self.HorizontalScale < drawArea.Dx(); j++ {
val := line[j]
height := int((val / maxVal) * float64(drawArea.Dy()-1))
height := int(((val - minVal) / r) * float64(drawArea.Dy()-1))
buf.SetCell(
NewCell(self.DotMarkerRune, NewStyle(SelectColor(self.LineColors, i))),
image.Pt(drawArea.Min.X+(j*self.HorizontalScale), drawArea.Max.Y-1-height),
Expand All @@ -147,7 +149,8 @@ func (self *Plot) renderDot(buf *Buffer, drawArea image.Rectangle, maxVal float6
}
}

func (self *Plot) plotAxes(buf *Buffer, maxVal float64) {
func (self *Plot) plotAxes(buf *Buffer, minVal float64, maxVal float64) {
r := maxVal - minVal
// draw origin cell
buf.SetCell(
NewCell(BOTTOM_LEFT, NewStyle(ColorWhite)),
Expand Down Expand Up @@ -188,10 +191,11 @@ func (self *Plot) plotAxes(buf *Buffer, maxVal float64) {
x += (len(label) + xAxisLabelsGap) * self.HorizontalScale
}
// draw y axis labels
verticalScale := maxVal / float64(self.Inner.Dy()-xAxisLabelsHeight-1)
verticalScale := r / float64(self.Inner.Dy()-xAxisLabelsHeight-1)
for i := 0; i*(yAxisLabelsGap+1) < self.Inner.Dy()-1; i++ {
lblY := minVal + float64(i)*verticalScale*(yAxisLabelsGap+1)
buf.SetString(
fmt.Sprintf("%.2f", float64(i)*verticalScale*(yAxisLabelsGap+1)),
fmt.Sprintf("%.2f", lblY),
NewStyle(ColorWhite),
image.Pt(self.Inner.Min.X, self.Inner.Max.Y-(i*(yAxisLabelsGap+1))-2),
)
Expand All @@ -202,12 +206,14 @@ func (self *Plot) Draw(buf *Buffer) {
self.Block.Draw(buf)

maxVal := self.MaxVal
minVal := self.MinVal
if maxVal == 0 {
maxVal, _ = GetMaxFloat64From2dSlice(self.Data)
minVal, _ = GetMinFloat64From2dSlice(self.Data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if maxVal == 0, the minVal will be re-calculated even user sets this value by purpose?

}

if self.ShowAxes {
self.plotAxes(buf, maxVal)
self.plotAxes(buf, minVal, maxVal)
}

drawArea := self.Inner
Expand All @@ -220,8 +226,8 @@ func (self *Plot) Draw(buf *Buffer) {

switch self.Marker {
case MarkerBraille:
self.renderBraille(buf, drawArea, maxVal)
self.renderBraille(buf, drawArea, minVal, maxVal)
case MarkerDot:
self.renderDot(buf, drawArea, maxVal)
self.renderDot(buf, drawArea, minVal, maxVal)
}
}