Updates for build.gradle and tested Proguard#3
Updates for build.gradle and tested Proguard#3jaredsburrows wants to merge 1 commit intogk5885:masterfrom jaredsburrows:master
Conversation
build.gradle
Outdated
There was a problem hiding this comment.
This whole task is not needed. Once the wrapper has been checked in you can just edit the properties file to update it.
|
@JakeWharton I have removed the extra task and used the |
|
Multidex works fine with Dagger 2. It just doesn't work with the current architecture. It would be trivial to alter the behavior. |
|
@JakeWharton You have used MultiDex + DI before? I have had issues with Roboguice + MultiDex in the past. What do you mean current architecture? |
|
The documentation for multidex states that you need to defer having classes The current design forces Dagger classes to be loaded before the multidex However, I don't think we should attempt to showcase absolutely every
|
|
@JakeWharton I understand. I just wanted to be able to add Proguard to the working Android sample that uses Dagger 2.0. Should I remove the MultiDex line? |
|
Yeah let's remove it. We'll make another app sample somewhere to showcase
|
Added and tested Proguard
@JakeWharton Will you showcase Dagger 2.0 + MutliDex in a separate project soon? I was hoping to utilize both Proguard and MultiDex with Dagger 2.0. |
|
Proguard should work without any actual changes. But yeah we can make a
|
|
@JakeWharton Yes! I saw you posted that somewhere. I agree and I would like to contribute. You posted here: |
|
@gk5885 @JakeWharton Was there anything else that needed to change for this pull request? |
|
@gk5885 Any updates on this? |
buildToolsVersioninbuild.gradlecom.android.tools.build:gradleinbuild.gradlewrapperreleasetobuildTypesenabling Proguard withminifyEnabledandshrinkResourceswhich verifies: http://stackoverflow.com/questions/26024694/how-to-successfully-obfuscate-project-with-dagger-2-0-using-proguard