Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dist/ directory in repo #5

Open
maxdeviant opened this issue May 23, 2024 · 4 comments · May be fixed by #6
Open

Include dist/ directory in repo #5

maxdeviant opened this issue May 23, 2024 · 4 comments · May be fixed by #6

Comments

@maxdeviant
Copy link

I opened a PR to add Gleam to the list of Highlight.js grammars: highlightjs/highlight.js#4049.

It was requested that the dist/ directory be included, as outlined in the "Create your repository" section of the third-party docs.

Generating the dist/ directory is outlined in the "Packaging" section.

Note that this is only needed prior to v12 of Highlight.js:

This need will disappear with v12, but while the core library is available in both CJS and ES6 module this makes sense.

Is this something we want to move forward with?

@lpil
Copy link
Member

lpil commented May 24, 2024

Huh! OK. When does v12 land?

@maxdeviant
Copy link
Author

Huh! OK. When does v12 land?

Summer 2022, apparently 😅

Screenshot 2024-05-24 at 10 35 48 AM

@lpil
Copy link
Member

lpil commented May 29, 2024

lmao. OK I guess we include it!

@maxdeviant
Copy link
Author

lmao. OK I guess we include it!

Cool, I can put a PR together.

@maxdeviant maxdeviant linked a pull request Jun 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants