-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement renaming for Functions, Constants and Type Variants #4282
base: main
Are you sure you want to change the base?
Implement renaming for Functions, Constants and Type Variants #4282
Conversation
d4c87d0
to
1f931b9
Compare
Ok, this is ready for review now. I'm not super happy with the way I fixed the module access shadowing bug, but I couldn't think of another way to do it. Let me know if you have any thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice!! I'm really excited about this one.
I've not finished reviewing totally but I've gotta go so I wanted to drop my thoughts so far. See inline notes.
...am_core__language_server__tests__rename__rename_type_variant_from_unqualified_reference.snap
Show resolved
Hide resolved
Ok, I have now added the reference information to the cache so we can rename values in cached modules. |
aa0d57e
to
5e00fad
Compare
This should be ready for review again. |
6476e42
to
0e230df
Compare
This PR closes #3259
This is pretty much ready, except for two things: