Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scientific notation syntax highlighting #60

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Fix scientific notation syntax highlighting #60

merged 3 commits into from
Mar 15, 2024

Conversation

Manueljlin
Copy link
Contributor

Fixes #59
Before:
image

After:
image

@Manueljlin Manueljlin changed the title Work/mn/fix scientific notation Fix scientific notation Mar 14, 2024
@Manueljlin Manueljlin changed the title Fix scientific notation Fix scientific notation syntax highlighting Mar 14, 2024
@Manueljlin
Copy link
Contributor Author

Note: it still doesn't add the syntax highlighting for the decimal separators, like other languages do:

image

I believe that would be covered by PR #30

lpil
lpil approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Impressive regex skills 🥷

@lpil lpil merged commit 755b168 into gleam-lang:main Mar 15, 2024
@Manueljlin Manueljlin deleted the work/mn/fix-scientific-notation branch March 15, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scientific notation doesn't get highlighted properly
2 participants
@Manueljlin @lpil