Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 2 moderate severity vulnerabilities #85

Merged
merged 2 commits into from
Jul 18, 2024
Merged

fix: 2 moderate severity vulnerabilities #85

merged 2 commits into from
Jul 18, 2024

Conversation

hamirmahal
Copy link
Contributor

fixes #84.

hamirmahal
hamirmahal commented Jun 27, 2024
View reviewed changes
Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should fix the 2 moderate severity vulnerabilities, while switching to the correct vsce package.

lpil
lpil reviewed Jun 30, 2024
View reviewed changes
package.json Outdated
"vscode-test": "^1.4.1",
"webpack": "^5.76.0",
"webpack-cli": "^4.9.2"
},
"dependencies": {
"@vscode/vsce": "^2.29.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a dev dep, could you move it over please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my mistake. I fixed it. Thank you for catching that.

@hamirmahal hamirmahal requested a review from lpil June 30, 2024 19:53
lpil
lpil approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lpil lpil merged commit 04be281 into gleam-lang:main Jul 18, 2024
@hamirmahal hamirmahal deleted the fix/2-moderate-severity-vulnerabilities-and-usage-of-deprecated-vsce-package branch July 18, 2024 16:03
@hamirmahal
Copy link
Contributor Author

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies have 2 moderate severity vulnerabilities and use deprecated vsce package
2 participants
@hamirmahal @lpil