Update to match last version of gleam #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 26, 2024 17:08
- Equality operators are the same for all types - Modulo operator does not make sens for floats - Fixing multiple regexes - Missing 'Nil' highlight
Betelgeuse1
changed the title
lpil
reviewed
Jul 26, 2024
syntaxes/gleam.tmLanguage.json
Outdated
| @@ -26,7 +26,7 @@ | |||
| "patterns": [ | |||
| { | |||
| "name": "keyword.control.gleam", | |||
| "match": "\\b(as|use|case|if|fn|import|let|assert|pub|type|opaque|const|todo|panic)\\b" | |||
| "match": "\\b(import|pub|panic|use|type|let|as|if|else|todo|const|case|assert|try|opaque|fn)\\b" | |||
There was a problem hiding this comment.
What's the difference here? Please don't make meaningless formatting changes as it makes it very challenging to review
syntaxes/gleam.tmLanguage.json
Outdated
| }, | ||
| "nil": { | ||
| "name": "constant.language.null.gleam", | ||
| "match": "\\bNil\\b", |
There was a problem hiding this comment.
Remove this. Nil is not a special type and should not get special treatment.
syntaxes/gleam.tmLanguage.json
Outdated
| "patterns": [] | ||
| }, | ||
| "decimal_number": { | ||
| "name": "constant.numeric.decimal.gleam", | ||
| "match": "\\b[[:digit:]]+(_?[[:digit:]])*(\\.[[:digit:]]*)?(e-?[[:digit:]]*)?\\b", | ||
| "match": "\\b[[:digit:]](_?[[:digit:]])*(\\.([[:digit:]](_?[[:digit:]])*)?(e-?[[:digit:]]|[[:digit:]]?)(_?[[:digit:]])*)?\\b", |
syntaxes/gleam.tmLanguage.json
Outdated
| } | ||
| ] | ||
| }, | ||
| "binary_number": { | ||
| "name": "constant.numeric.binary.gleam", | ||
| "match": "\\b0[bB](_?[01])+\\b", | ||
| "match": "\\b0[bB][01]+\\b", |
syntaxes/gleam.tmLanguage.json
Outdated
| "patterns": [] | ||
| }, | ||
| "octal_number": { | ||
| "name": "constant.numeric.octal.gleam", | ||
| "match": "\\b0[oO](_?[0-7])+\\b", | ||
| "match": "\\b0[oO][0-7]+\\b", |
added 4 commits
July 26, 2024 20:56
|
@lpil |
|
Oh, that's a mistake. |
Betelgeuse1
pushed a commit
to Betelgeuse1/vim-polyglot
that referenced
this pull request
Jul 31, 2024
See gleam-lang/vscode-gleam#86 (comment) > @lpil > Oh, that's a mistake. Nil, True, and False should not get special treatment. I will fix that bug.
lpil
reviewed
Aug 1, 2024
lpil
pushed a commit
that referenced
this pull request
Aug 15, 2024
lpil
pushed a commit
that referenced
this pull request
Aug 15, 2024
lpil
pushed a commit
that referenced
this pull request
Aug 15, 2024
lpil
pushed a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just created another pull request to fix gleam.vim issues too. Since I was at it, I thought I would fix issues here too.
Sadly, I couldn't test my changes yet, let me know if something seems off :)
Fixes :