-
Notifications
You must be signed in to change notification settings - Fork 279
Silence parser warning and patch version mismatch when loading parser/current #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bab4793
Implement RubyParserFactory to avoid warning when requiring parser/cu…
navidemad cd54e38
Add entry to changelog
navidemad 186f47f
Fix json error 'messages' must contain the word 'json' in some form, …
navidemad 19e0b65
Remove unrelated PR to their own
navidemad 97f9ffb
Fix Rubocop linting errors
navidemad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # This module provides a factory class for creating a Ruby parser instance. | ||
| # It temporarily disables verbose mode to suppress compatibility warnings | ||
| # when loading the "parser/current" library. | ||
| # | ||
| # Example warning for the release of Ruby 3.4.1: | ||
| # warning: parser/current is loading parser/ruby34, which recognizes | ||
| # 3.4.0-compliant syntax, but you are running 3.4.1. | ||
| # Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. | ||
| # | ||
| # By disabling verbose mode, these warnings are suppressed to provide a cleaner | ||
| # output and avoid confusion. The verbose mode is restored after the parser | ||
| # instance is created to maintain the original behavior. | ||
|
|
||
| module I18n::Tasks::Scanners | ||
| class RubyParserFactory | ||
| def self.create_parser | ||
| prev = $VERBOSE | ||
| $VERBOSE = nil | ||
| require 'parser/current' | ||
| ::Parser::CurrentRuby.new | ||
| ensure | ||
| $VERBOSE = prev | ||
| end | ||
| end | ||
| end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a much nicer solution to this would be to send a PR to whitequark/parser adding an argument to
Parser::CurrentRuby.newthat disables the warningThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made whitequark/parser#1065 we will see, but yeah you are right fixing it on the parser itself it's better, than hotfixing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They won't update their parser with Ruby >3.4 so we're stuck