Make OMERO object column detection case-insensitive #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Conceptually supporting case insensitive column names is consistent with the current behavior of omero-metadata as described in https://github.com/ome/omero-metadata#populate.
Could the README be also updated to capture the expectations in terms of mapping Pandas columns into typed OMERO columns?
|
@sbesson How does this read? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in CSV mode an OMERO object column must be named in lower case to be picked up and registered as a formal object column. This PR makes this detection case-insensitive, so a column called
ROIbecomes an ROIColumn instead of requiring it be namedroi.