Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package specification and build system #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DavidStirling
Copy link
Member

Key changes:

  • Migrate to pyproject.toml project specification format
  • Revise GH actions workflow using the newer template
  • Replace version.py with setuptools-scm
  • Drop support for EOL Python versions (3.6-3.8)

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration of the package to use pyproject.toml is consistent with the steps taken in other projects.

At the CI level, only consideration is whether the reduction of the test matrix to a single Python version on Linux can reduce coverage. I'll leave @emilroz to comment on the latter as he originally introduced the workflow YAML file.

@sbesson sbesson requested a review from emilroz December 11, 2024 14:26
@DavidStirling
Copy link
Member Author

Thanks Seb. I opted to drop the matrix primarily because we don't actually have a test suite and our wheels are cross-platform. In effect all we're really doing with the current system is running flake8 on several different Python versions.

@emilroz
Copy link
Member

emilroz commented Dec 11, 2024

At the CI level, only consideration is whether the reduction of the test matrix to a single Python version on Linux can reduce coverage. I'll leave @emilroz to comment on the latter as he originally introduced the workflow YAML file.

Would it make sense to at least cover 3.10 & 3.12?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants