Drop logging configuration settings #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two problems:
WARNING
and above. This can lead to a counterintuitive scenario where the user expects to seeINFO
messages, but omero2pandas has suppressed them.I think the solution here is to not be opinionated about logging format at all. We'll let omero2pandas use whatever was configured by the application calling it. Since we (currently?) don't offer a CLI we shouldn't need to touch the root logger ourselves.
Testing
Make a simple test script:
When run this produces:
This happens as omero2pandas applied it's logging settings.
Comment out
import omero2pandas
and you should get:With this PR you should always get the latter result.