Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup release it #1448

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Setup release it #1448

merged 5 commits into from
Oct 23, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Oct 12, 2023

Hopefully this works 🤞

but the output looks suspicious
it kinda looks like the versions need to be disabled, yeah?
like, we don't want the dependency version bumps to be committed to source.

What we want to happen:

Then,


Tested locally with:

❯ npx release-it --dry-run --no-git.push --no-git.requireUpstream

Which gives:

❯ npx release-it --dry-run --no-git.push --no-git.requireUpstream
! npm ping --registry https://registry.npmjs.org
! npm whoami --registry https://registry.npmjs.org
$ git describe --tags --abbrev=0
$ /home/nvp/.volta/tools/image/node/20.1.0/bin/node /home/nvp/Development/OpenSource/emberjs/glimmer-vm-2/node_modules/.pnpm/[email protected]/node_modules/lerna-changelog/bin/cli.js --next-version=Unreleased --from=v0.84.3
$ git diff --quiet HEAD
$ git rev-parse --abbrev-ref HEAD
$ git config --get branch.setup-release-it-for-monorepos.remote
$ git remote get-url origin
! git fetch
$ git rev-parse --abbrev-ref HEAD  [cached]
$ git describe --tags --match=* --abbrev=0

🚀 Let's release glimmer-vm (currently at 0.84.3)


Changelog:

## Unreleased (2023-10-23)
#### :rocket: Enhancement
* `@glimmer/compiler`, `@glimmer/debug`, `@glimmer/dom-change-list`, `@glimmer/integration-tests`, `@glimmer/interfaces`, `@glimmer/opcode-compiler`, `@glimmer/runtime`, `@glimmer/syntax`, `@glimmer/validator`, `@glimmer/vm`
  * [#1421](https://github.com/glimmerjs/glimmer-vm/pull/1421) Improve lexical scope ([@wycats](https://github.com/wycats))
* `@glimmer/syntax`
  * [#1420](https://github.com/glimmerjs/glimmer-vm/pull/1420) [syntax] Remove v2-b and rename v2-a to v2 ([@wycats](https://github.com/wycats))
#### :bug: Bug Fix
* `@glimmer/syntax`
  * [#1412](https://github.com/glimmerjs/glimmer-vm/pull/1412) Fix another issue with getTemplateLocals and block params ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
#### :house: Internal
* Other
  * [#1444](https://github.com/glimmerjs/glimmer-vm/pull/1444) Add release workflow ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
  * [#1437](https://github.com/glimmerjs/glimmer-vm/pull/1437) GH Actions: Move to wyvox and off branch ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
  * [#1415](https://github.com/glimmerjs/glimmer-vm/pull/1415) Try upgrading ember-cli-browserstack ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
* `@glimmer-workspace`, `@glimmer-workspace/benchmark-env`, `@glimmer-workspace/build`, `@glimmer-workspace/eslint-plugin`, `@glimmer-workspace/integration-tests`, `@glimmer-workspace/test-utils`, `@glimmer`, `@glimmer/compiler`, `@glimmer/debug`, `@glimmer/destroyable`, `@glimmer/dom-change-list`, `@glimmer/encoder`, `@glimmer/global-context`, `@glimmer/integration-tests`, `@glimmer/interfaces`, `@glimmer/local-debug-flags`, `@glimmer/manager`, `@glimmer/node`, `@glimmer/opcode-compiler`, `@glimmer/owner`, `@glimmer/program`, `@glimmer/reference`, `@glimmer/runtime`, `@glimmer/syntax`, `@glimmer/test-utils`, `@glimmer/util`, `@glimmer/validator`, `@glimmer/vm-babel-plugins`, `@glimmer/vm`, `@glimmer/wire-format`, `@types`, `@types/qunit`, `build-utils`
  * [#1427](https://github.com/glimmerjs/glimmer-vm/pull/1427) Restore performance tests ([@wycats](https://github.com/wycats))
* `@glimmer`, `@glimmer/benchmark-env`, `@glimmer/compiler`, `@glimmer/destroyable`, `@glimmer/dom-change-list`, `@glimmer/integration-tests`, `@glimmer/interfaces`, `@glimmer/manager`, `@glimmer/opcode-compiler`, `@glimmer/owner`, `@glimmer/program`, `@glimmer/reference`, `@glimmer/runtime`, `@glimmer/syntax`, `@glimmer/util`, `@glimmer/validator`, `@glimmer/vm`, `@types`, `@types/puppeteer-chromium-resolver`, `@types/qunit`, `build-utils`
  * [#1426](https://github.com/glimmerjs/glimmer-vm/pull/1426) Follow-up migrate to vite (restore type tests) ([@wycats](https://github.com/wycats))
* `@glimmer/benchmark-env`, `@glimmer/compiler`, `@glimmer/debug`, `@glimmer/destroyable`, `@glimmer/dom-change-list`, `@glimmer/encoder`, `@glimmer/global-context`, `@glimmer/integration-tests`, `@glimmer/interfaces`, `@glimmer/local-debug-flags`, `@glimmer/manager`, `@glimmer/node`, `@glimmer/opcode-compiler`, `@glimmer/owner`, `@glimmer/program`, `@glimmer/reference`, `@glimmer/runtime`, `@glimmer/syntax`, `@glimmer/test-utils`, `@glimmer/util`, `@glimmer/validator`, `@glimmer/vm`, `@glimmer/wire-format`, `@types/js-reporters`, `@types/qunit`
  * [#1423](https://github.com/glimmerjs/glimmer-vm/pull/1423) Migrate to Vite ([@NullVoxPopuli](https://github.com/NullVoxPopuli))
* `@glimmer/debug`, `@glimmer/dom-change-list`, `@glimmer/integration-tests`, `@glimmer/interfaces`, `@glimmer/node`, `@glimmer/runtime`, `@glimmer/syntax`, `@glimmer/validator`
  * [#1419](https://github.com/glimmerjs/glimmer-vm/pull/1419) Continue updating infrastructure ([@wycats](https://github.com/wycats))
* `@glimmer/benchmark-env`, `@glimmer/compiler`, `@glimmer/debug`, `@glimmer/destroyable`, `@glimmer/dom-change-list`, `@glimmer/encoder`, `@glimmer/integration-tests`, `@glimmer/interfaces`, `@glimmer/manager`, `@glimmer/node`, `@glimmer/opcode-compiler`, `@glimmer/owner`, `@glimmer/program`, `@glimmer/reference`, `@glimmer/runtime`, `@glimmer/syntax`, `@glimmer/util`, `@glimmer/validator`, `@glimmer/vm`, `@glimmer/wire-format`
  * [#1418](https://github.com/glimmerjs/glimmer-vm/pull/1418) Modernize Infrastructure ([@wycats](https://github.com/wycats))
#### Committers: 2
- Yehuda Katz ([@wycats](https://github.com/wycats))
- [@NullVoxPopuli](https://github.com/NullVoxPopuli)

? Select increment (next version): minor (0.85.0)
$ Processing packages/@glimmer/compiler/package.json:
$       version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/debug/package.json:
$       version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/destroyable/package.json:
$       version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/dom-change-list/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/encoder/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/global-context/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/interfaces/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/local-debug-flags/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/manager/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/node/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/opcode-compiler/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/owner/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/program/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/reference/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/runtime/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/syntax/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/util/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/validator/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/vm-babel-plugins/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/vm/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ Processing packages/@glimmer/wire-format/package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
$ 	dependencies: `@glimmer/util` -> 0.85.0 (from 0.84.3)
$ 	dependencies: `@glimmer/interfaces` -> 0.85.0 (from 0.84.3)
$ Processing additionManifest.versionUpdates for ./package.json:
$ 	version: -> 0.85.0 (from 0.84.3)
! Prepending CHANGELOG.md with release notes.
$ git status --short --untracked-files=no

Empty changeset

! git add . --update
? Commit (Release 0.85.0)? Yes
! git commit --message Release 0.85.0
? Tag (v0.85.0)? Yes
! git tag --annotate --message Release 0.85.0 v0.85.0
🏁 Done (in 34s.)

Copy link
Contributor

@chancancode chancancode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what @rwjblue suggested/requested in the upstream PR seems reasonable to me, but I agree this narrow patch should get the job done for now, for this particular use case right now to unblock releasing

@NullVoxPopuli NullVoxPopuli merged commit 3d94e94 into master Oct 23, 2023
5 checks passed
@NullVoxPopuli NullVoxPopuli deleted the setup-release-it-for-monorepos branch October 23, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants