Error Recovery

.editorconfig

@@ -6,6 +6,7 @@ root = true
 
 
 [*]
+max_line_length = 100
 end_of_line = lf
 charset = utf-8
 trim_trailing_whitespace = true
@@ -21,3 +22,4 @@ insert_final_newline = false
 
 [*.{diff,md}]
 trim_trailing_whitespace = false
+max_line_length = 80

.eslintrc.cjs

@@ -19,32 +19,32 @@ module.exports = {
     '**/fixtures',
     '!**/.eslintrc.cjs',
   ],
-  parser: '@typescript-eslint/parser',
-  parserOptions: {
-    ecmaVersion: 'latest',
-    project: [],
-  },
-  settings: {
-    'import/parsers': {
-      '@typescript-eslint/parser': ['.js', '.cjs', '.mjs', '.mts', '.ts', '.d.ts'],
-    },
-    'import/resolver': {
-      typescript: {},
-    },
-    node: {
-      allowModules: ['@glimmer/debug', '@glimmer/local-debug-flags'],
-      tryExtensions: ['.js', '.ts', '.d.ts', '.json'],
-    },
-  },
-  plugins: [
-    '@typescript-eslint',
-    'prettier',
-    'qunit',
-    'simple-import-sort',
-    'unused-imports',
-    'prettier',
-    'n',
-  ],
+  // parser: '@typescript-eslint/parser',
+  // parserOptions: {
+  //   ecmaVersion: 'latest',
+  //   project: [],
+  // },
+  // settings: {
+  //   'import/parsers': {
+  //     '@typescript-eslint/parser': ['.js', '.cjs', '.mjs', '.mts', '.ts', '.d.ts'],
+  //   },
+  //   'import/resolver': {
+  //     typescript: {},
+  //   },
+  //   node: {
+  //     allowModules: ['@glimmer/debug', '@glimmer/local-debug-flags'],
+  //     tryExtensions: ['.js', '.ts', '.d.ts', '.json'],
+  //   },
+  // },
+  // plugins: [
+  //   '@typescript-eslint',
+  //   'prettier',
+  //   'qunit',
+  //   'simple-import-sort',
+  //   'unused-imports',
+  //   'prettier',
+  //   'n',
+  // ],
 
   rules: {},
   overrides: [

.prettierrc.json

@@ -1,5 +1,6 @@
 {
   "singleQuote": true,
   "trailingComma": "es5",
-  "printWidth": 100
+  "printWidth": 100,
+  "plugins": []
 }

.vscode/extensions.json

@@ -0,0 +1,3 @@
+{
+  "recommendations": ["foxundermoon.shell-format"]
+}

.vscode/settings.json

@@ -9,11 +9,14 @@
   "[javascript][typescript]": {
     "editor.formatOnSave": false,
     "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.codeActionsOnSave": ["source.formatDocument", "source.fixAll.eslint"]
+    "editor.codeActionsOnSave": {
+      "source.unusedImports": "explicit",
+      "source.fixAll": "explicit",
+      "source.formatDocument": "always"
+    }
   },
   "editor.formatOnSave": true,
   "eslint.enable": true,
-  "eslint.packageManager": "npm",
   "eslint.codeAction.showDocumentation": {
     "enable": true
   },
@@ -25,7 +28,7 @@
       "mode": "auto"
     }
   ],
-  "explorer.excludeGitIgnore": false,
+  "explorer.excludeGitIgnore": true,
   "files.exclude": {
     "**/.DS_Store": true,
     "**/.git": true,
@@ -41,15 +44,190 @@
   "javascript.updateImportsOnFileMove.enabled": "always",
   "typescript.updateImportsOnFileMove.enabled": "always",
 
-  "typescript.preferences.importModuleSpecifier": "project-relative",
   "javascript.preferences.importModuleSpecifier": "project-relative",
+  "typescript.preferences.importModuleSpecifier": "project-relative",
 
-  "typescript.preferences.importModuleSpecifierEnding": "minimal",
+  "typescript.preferences.importModuleSpecifierEnding": "index",
   "typescript.preferences.useAliasesForRenames": false,
 
-  "typescript.tsc.autoDetect": "on",
   "typescript.tsdk": "node_modules/typescript/lib",
-  "typescript.tsserver.experimental.enableProjectDiagnostics": false,
+  "typescript.tsserver.experimental.enableProjectDiagnostics": true,
   "typescript.workspaceSymbols.scope": "currentProject",
-  "eslint.problems.shortenToSingleLine": true
+  "eslint.problems.shortenToSingleLine": true,
+  "inline-bookmarks.expert.custom.words.mapping": {
+    "warn": ["@premerge(\\s|$)"],
+    "active": ["@active(\\s|$)"],
+    "fixme": ["@fixme(\\s|$)"]
+  },
+  "inline-bookmarks.expert.custom.styles": {
+    "active": {
+      // teal
+      "gutterIconColor": "#009999",
+      "overviewRulerColor": "rgba(0, 150, 150, 0.7)",
+      "light": {
+        "fontWeight": "bold",
+        "color": "#009999"
+      },
+      "dark": {
+        "fontWeight": "bold",
+        "color": "#00ffff"
+      }
+    },
+    "fixme": {
+      // yellow
+      "gutterIconColor": "#990000",
+      "overviewRulerColor": "rgba(150, 0, 0, 0.7)",
+      "light": {
+        "fontWeight": "bold",
+        "color": "#990000"
+      },
+      "dark": {
+        "fontWeight": "bold",
+        "color": "#ff0000"
+      }
+    },
+    "warn": {
+      // yellow
+      "gutterIconColor": "#999900",
+      "overviewRulerColor": "rgba(150, 150, 0, 0.7)",
+      "light": {
+        "fontWeight": "bold",
+        "color": "#999900"
+      },
+      "dark": {
+        "fontWeight": "bold",
+        "color": "#ffff00"
+      }
+    }
+  },
+  "inline-bookmarks.view.showVisibleFilesOnly": true,
+  "commit-message-editor.staticTemplate": [
+    "feat: Short description",
+    "",
+    "Message body",
+    "",
+    "Message footer"
+  ],
+  "commit-message-editor.dynamicTemplate": [
+    "{type}{scope}: {description}",
+    "",
+    "{body}",
+    "",
+    "{breaking_change}{footer}"
+  ],
+  "commit-message-editor.tokens": [
+    {
+      "label": "Type",
+      "name": "type",
+      "type": "enum",
+      "options": [
+        {
+          "label": "---",
+          "value": ""
+        },
+        {
+          "label": "build",
+          "description": "Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)"
+        },
+        {
+          "label": "chore",
+          "description": "Updating grunt tasks etc; no production code change"
+        },
+        {
+          "label": "ci",
+          "description": "Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)"
+        },
+        {
+          "label": "docs",
+          "description": "Documentation only changes"
+        },
+        {
+          "label": "feat",
+          "description": "A new feature"
+        },
+        {
+          "label": "fix",
+          "description": "A bug fix"
+        },
+        {
+          "label": "editor",
+          "description": "A change to editor/IDE support"
+        },
+        {
+          "label": "infra",
+          "description": "A change to the build, test or CI infrastructure"
+        },
+        {
+          "label": "perf",
+          "description": "A code change that improves performance"
+        },
+        {
+          "label": "refactor",
+          "description": "A code change that neither fixes a bug nor adds a feature"
+        },
+        {
+          "label": "revert"
+        },
+        {
+          "label": "style",
+          "description": "Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)"
+        },
+        {
+          "label": "test",
+          "description": "Adding missing tests or correcting existing tests"
+        }
+      ],
+      "description": "Type of changes"
+    },
+    {
+      "label": "Scope",
+      "name": "scope",
+      "description": "A scope may be provided to a commit’s type, to provide additional contextual information and is contained within parenthesis, e.g., \"feat(parser): add ability to parse arrays\".",
+      "type": "text",
+      "multiline": false,
+      "prefix": "(",
+      "suffix": ")"
+    },
+    {
+      "label": "Short description",
+      "name": "description",
+      "description": "Short description in the subject line.",
+      "type": "text",
+      "multiline": false
+    },
+    {
+      "label": "Body",
+      "name": "body",
+      "description": "Optional body",
+      "type": "text",
+      "multiline": true,
+      "lines": 5,
+      "maxLines": 10
+    },
+    {
+      "label": "Breaking change",
+      "name": "breaking_change",
+      "type": "boolean",
+      "value": "BREAKING CHANGE: ",
+      "default": false
+    },
+    {
+      "label": "Footer",
+      "name": "footer",
+      "description": "Optional footer",
+      "type": "text",
+      "multiline": true
+    }
+  ],
+  "surround.custom": {
+    "register": {
+      "label": "register helper",
+      "snippet": "{ ${1:helper}: $TM_SELECTED_TEXT }"
+    }
+  },
+  "rewrap.wrappingColumn": 100,
+  "rewrap.onSave": false,
+  "rewrap.autoWrap.enabled": true,
+  "rewrap.reformat": true,
+  "rewrap.wholeComment": false
 }

TODO.md

@@ -0,0 +1,13 @@
+- [ ] Implement `#try` that takes handler
+  - [ ] internal `{{#if isClear}}{{!-- actual code --}}{{/if}}`
+  - [ ] if an error is encountered, unwind as-if isClear was false
+        during the render pass
+    - [ ] when you encounter the enter of the try, insert a marker in
+          every VM stack.
+    - [ ] every stack in the VM needs "unwind to nearest marker"
+    - [ ] when a render error is encountered, unwind all the stacks
+    - [ ] call the handler with the error
+  - [ ] no catch
+  - [ ] the handler has a way to clear the error
+  - [ ] deal with user destructors that should run even during render errors
+    - [ ] maintain the invariant that constructors and destructors are paired

bin/.eslintrc.cjs

@@ -7,7 +7,6 @@ module.exports = {
   root: false,
   env: {
     es6: true,
-    node: true,
   },
   overrides: [
     {

bin/codemods/devmode.toml

@@ -0,0 +1,7 @@
+[devmode]
+match = "devmode({ :[block] })"
+rewrite = "devmode(() => ({ :[block] }))"
+
+[devmode2]
+match = "if (import.meta.env.DEV) { :[[name]].description = :[description]; }"
+rewrite = "setDescription(:[name], devmode(() => :[description]));"

bin/codemods/new-spec-suite.toml

@@ -0,0 +1,21 @@
+[test]
+match = """
+export class :[class] extends :[extends] {
+  static suiteName = :[suite];
+  :[block]
+}
+"""
+rewrite = """
+import { matrix } from "@glimmer-workspace/integration-tests";
+matrix(:[suite], (spec) => { :[block] }).client();
+"""
+rule = """
+where
+rewrite :[block] { "this" -> "ctx" },
+rewrite :[block] {
+  "@render(:[type]) :[string]() { :[body] }" -> "spec({ type: :[type] }, :[string], (ctx) => { :[body] })"
+},
+rewrite :[block] {
+  "@render :[string]() { :[body] }" -> "spec(:[string], (ctx) => { :[body] })"
+}
+"""