Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare all workspace protocols workspace:* so that patch bumps bump all consumers as well #1616

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

No description provided.

@NullVoxPopuli NullVoxPopuli merged commit 22ddb36 into main Sep 11, 2024
8 checks passed
@NullVoxPopuli NullVoxPopuli deleted the declare-all-workspace-packages-to-be-tighter branch September 11, 2024 22:20
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Copy link

duration phase no difference [-84ms to 23ms]
renderEnd phase no difference [-2ms to 1ms]
render1000Items1End phase no difference [-5ms to 11ms]
clearItems1End phase no difference [-4ms to 1ms]
render1000Items2End phase no difference [-2ms to 11ms]
clearItems2End phase no difference [-1ms to 0ms]
render5000Items1End phase estimated improvement -27ms [-45ms to -9ms] OR -0.75% [-1.27% to -0.24%]
clearManyItems1End phase no difference [-2ms to 1ms]
render5000Items2End phase no difference [-21ms to 23ms]
clearManyItems2End phase no difference [-3ms to 3ms]
render1000Items3End phase no difference [-15ms to 9ms]
append1000Items1End phase no difference [-11ms to 22ms]
append1000Items2End phase no difference [-2ms to 12ms]
updateEvery10thItem1End phase no difference [-3ms to 0ms]
updateEvery10thItem2End phase no difference [0ms to 0ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [0ms to 0ms]
removeSecondRow1End phase no difference [0ms to 0ms]
swapRows1End phase no difference [0ms to 0ms]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase no difference [-2ms to 1ms]
paint phase no difference [0ms to 0ms]

[23:04:11] Generating Benchmark Reports [started]
[23:04:19] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant