Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug alias for let #1631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patricklx
Copy link
Contributor

This helps especially on cases for e.g.
When one has a let var which collides with a html element

{{#let x as |b|}}
  {{b}}
  <b\>
{{/let}}

@NullVoxPopuli
Copy link
Contributor

Any ideas an the perf check failing? (It's failing on all branches)

We can't really merge anything until that's fixed :(

@patricklx patricklx force-pushed the add-debug-alias-for-let branch 2 times, most recently from 0025c4a to 8730a06 Compare October 18, 2024 11:53
@NullVoxPopuli NullVoxPopuli force-pushed the add-debug-alias-for-let branch from 8730a06 to f8ce3f3 Compare October 19, 2024 03:50
NullVoxPopuli
NullVoxPopuli previously approved these changes Oct 19, 2024
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good
Screenshot_20241019-075938

@NullVoxPopuli NullVoxPopuli dismissed their stale review October 22, 2024 22:44

Dismissing because we want to go more in a direction that exposes what the user typed, rather than try to derive debug aliases / names from existing runtime information --- here is an example: #1634 -- @wycats is currently thinking about this PR and is actively workingish on it -- this way when folks import something and alias it, we use the alias name, rather than the name it was defined with (current behavior as implemented)

@patricklx
Copy link
Contributor Author

patricklx commented Oct 28, 2024

@wycats i saw you are working on this. Maybe this us already fixed?

@patricklx
Copy link
Contributor Author

Btw, this is not derived debug alias, but the actual debug symbol what the user typed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants