Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening for discussion on whether this is a good direction to solve emberjs/babel-plugin-ember-template-compilation#61
You can see the other half of the changes in:
emberjs/babel-plugin-ember-template-compilation#67
which patches this PR's changes into ember-template-compiler.js.
The idea here is that
@glimmer/syntax
continues to just trust the outer layer (babel-plugin-ember-template-compilation) to manage all aspects of JS scope, including whether or notthis
should be considered to in local scope. If it's in scope, it compiles to a normal variable reference.