Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing PWN 3.1 ILI maps #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add some missing PWN 3.1 ILI maps #21

wants to merge 5 commits into from

Conversation

jmccrae
Copy link
Member

@jmccrae jmccrae commented Oct 31, 2024

As discussed in #16 some of the mappings that are reported as changed in PWN 3.1 are in fact not and have ILI codes. This PR fixes this by putting back all the matching synsets with the correct ILI

@fcbond
Copy link
Member

fcbond commented Nov 6, 2024

This has several mappings from one ili to multiple synsets, which is not allowed:

  • we should probably try to add an automated test for this
  • a simple one-liner for the tab file is
$ sort ili-map-pwn31.tab | cut -f 1 | uniq -d
i10616
i114673
i114674
i114676
i114677
i114679
i114680
i16842
i25156
i34688
i3764
i4234
i4304
i55794
i55822
i56320
i56630

I think we should also check the ili.ttl file as well.

Remove all deprecations as these are not clear and some have been
restored by other projects
@jmccrae
Copy link
Member Author

jmccrae commented Nov 8, 2024

I updated the branch so it has no duplicates and ILI to PWN 3.1 mappings are correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants