Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation of escaped XML IDs, escaping of colon #1109

Merged
merged 14 commits into from
Oct 11, 2024

Conversation

1313ou
Copy link
Contributor

@1313ou 1313ou commented Oct 7, 2024

see #1107

affects 3+1 entries which will change upon regeneration of XML

señor, señora, señorita -> oewn-señor-n, etc (ñ is valid in XML IDs)
Capital: Critique of Political Economy -> oewn-Capital-cn-_Critique_of_Political_Economy-n (: is not valid in XML IDs)

jmccrae and others added 5 commits September 30, 2024 13:20
This PR deletes most of the (unused) scripts in favour of two short
(`from_yaml.py` and `validate.py`)

We also introduce a `TOOLS.md` to the read me

Closes globalwordnet#1030
…aping of colon to avoid possible collision with cl (centilitre)
@1313ou
Copy link
Contributor Author

1313ou commented Oct 7, 2024

requires changing
valid_id = re.compile("^oewn-[A-Za-z0-9_\\-.]*$")
in validate.py:181
will do it later

@jmccrae jmccrae added this to the 2024 Release milestone Oct 11, 2024
@jmccrae jmccrae merged commit 35aee24 into globalwordnet:main Oct 11, 2024
1 check passed
@1313ou 1313ou deleted the pr_esc branch December 17, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants